* [Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()
@ 2017-08-04 10:39 Andrew Price
2017-08-04 12:01 ` Andreas Gruenbacher
2017-08-04 12:58 ` Bob Peterson
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Price @ 2017-08-04 10:39 UTC (permalink / raw)
To: cluster-devel.redhat.com
Commit 64b8e0b83eaa "gfs2: gfs2_glock_get: Wait on freeing glocks"
missed removing the final rcu_read_unlock() call.
Signed-off-by: Andrew Price <anprice@redhat.com>
---
fs/gfs2/glock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index fcbe478480f7..5ad757f0ce60 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -881,7 +881,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number,
atomic_dec(&sdp->sd_glock_disposal);
out:
- rcu_read_unlock();
return ret;
}
--
2.13.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()
2017-08-04 10:39 [Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get() Andrew Price
@ 2017-08-04 12:01 ` Andreas Gruenbacher
2017-08-04 12:58 ` Bob Peterson
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Gruenbacher @ 2017-08-04 12:01 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Fri, Aug 4, 2017 at 12:39 PM, Andrew Price <anprice@redhat.com> wrote:
> Commit 64b8e0b83eaa "gfs2: gfs2_glock_get: Wait on freeing glocks"
> missed removing the final rcu_read_unlock() call.
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
> fs/gfs2/glock.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index fcbe478480f7..5ad757f0ce60 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -881,7 +881,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number,
> atomic_dec(&sdp->sd_glock_disposal);
>
> out:
> - rcu_read_unlock();
> return ret;
> }
It seems this fails on preemptible kernels only, so we didn't see it
in our previous testing.
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Thanks,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get()
2017-08-04 10:39 [Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get() Andrew Price
2017-08-04 12:01 ` Andreas Gruenbacher
@ 2017-08-04 12:58 ` Bob Peterson
1 sibling, 0 replies; 3+ messages in thread
From: Bob Peterson @ 2017-08-04 12:58 UTC (permalink / raw)
To: cluster-devel.redhat.com
----- Original Message -----
| Commit 64b8e0b83eaa "gfs2: gfs2_glock_get: Wait on freeing glocks"
| missed removing the final rcu_read_unlock() call.
|
| Signed-off-by: Andrew Price <anprice@redhat.com>
| ---
Hi,
Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=7bfd81576ec4d6b7d463cae3dd4a43ac1323cc30
Regards,
Bob Peterson
Red Hat File Systems
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-04 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-04 10:39 [Cluster-devel] [PATCH] gfs2: Remove a missed rcu_read_unlock() in gfs2_glock_get() Andrew Price
2017-08-04 12:01 ` Andreas Gruenbacher
2017-08-04 12:58 ` Bob Peterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).