From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 4/4] mkfs.gfs2: Add align option and update docs
Date: Thu, 6 Jun 2013 09:13:27 -0400 (EDT) [thread overview]
Message-ID: <1604364747.48079746.1370524407342.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1370520213-29676-4-git-send-email-anprice@redhat.com>
Hi,
----- Original Message -----
| + for (i = 0; options[i] != NULL; i+=2) {
Just a nit here, but I'd recommend adding spaces, as per our standard: "i += 2"
| + printf("%15s %-22s\n", options[i], options[i+1]);
Same here: "i + 1"
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2013-06-06 13:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 12:03 [Cluster-devel] [PATCH 1/4] mkfs.gfs2: Set sunit and swidth from probed io limits Andrew Price
2013-06-06 12:03 ` [Cluster-devel] [PATCH 2/4] mkfs.gfs2: Align resource groups to RAID stripes Andrew Price
2013-06-06 12:06 ` Steven Whitehouse
2013-06-06 12:19 ` Andrew Price
2013-06-06 12:57 ` Bob Peterson
2013-06-06 13:04 ` Andrew Price
2013-06-06 13:17 ` Bob Peterson
2013-06-06 13:11 ` Steven Whitehouse
2013-06-06 13:30 ` Bob Peterson
2013-06-06 15:17 ` Andrew Price
2013-06-06 12:03 ` [Cluster-devel] [PATCH 3/4] mkfs.gfs2: Create new resource groups on-demand Andrew Price
2013-06-06 13:07 ` Bob Peterson
2013-06-06 13:50 ` Andrew Price
2013-06-06 12:03 ` [Cluster-devel] [PATCH 4/4] mkfs.gfs2: Add align option and update docs Andrew Price
2013-06-06 12:15 ` Steven Whitehouse
2013-06-06 12:45 ` Andrew Price
2013-06-06 12:53 ` Steven Whitehouse
2013-06-06 13:13 ` Bob Peterson [this message]
2013-06-06 13:53 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604364747.48079746.1370524407342.JavaMail.root@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).