* [Cluster-devel] [GFS2 Patch] GFS2: Eliminate gfs2_rg_lops [not found] <871458792.21418809.1369147754601.JavaMail.root@redhat.com> @ 2013-05-21 14:54 ` Bob Peterson 2013-05-22 10:40 ` Steven Whitehouse 0 siblings, 1 reply; 2+ messages in thread From: Bob Peterson @ 2013-05-21 14:54 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, With recent changes to the transactions, it appears that we are no longer using the "log ops" for resource groups. Since the log commit code processes the array of log ops, eliminating this should be marginally better for performance. Therefore this patch eliminates it. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson <rpeterso@redhat.com> --- fs/gfs2/lops.c | 5 ----- fs/gfs2/lops.h | 1 - 2 files changed, 6 deletions(-) diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index e069041..0457768 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c @@ -850,10 +850,6 @@ const struct gfs2_log_operations gfs2_revoke_lops = { .lo_name = "revoke", }; -const struct gfs2_log_operations gfs2_rg_lops = { - .lo_name = "rg", -}; - const struct gfs2_log_operations gfs2_databuf_lops = { .lo_before_commit = databuf_lo_before_commit, .lo_after_commit = databuf_lo_after_commit, @@ -865,7 +861,6 @@ const struct gfs2_log_operations gfs2_databuf_lops = { const struct gfs2_log_operations *gfs2_log_ops[] = { &gfs2_databuf_lops, &gfs2_buf_lops, - &gfs2_rg_lops, &gfs2_revoke_lops, NULL, }; diff --git a/fs/gfs2/lops.h b/fs/gfs2/lops.h index 87e062e..9ca2e64 100644 --- a/fs/gfs2/lops.h +++ b/fs/gfs2/lops.h @@ -23,7 +23,6 @@ extern const struct gfs2_log_operations gfs2_glock_lops; extern const struct gfs2_log_operations gfs2_buf_lops; extern const struct gfs2_log_operations gfs2_revoke_lops; -extern const struct gfs2_log_operations gfs2_rg_lops; extern const struct gfs2_log_operations gfs2_databuf_lops; extern const struct gfs2_log_operations *gfs2_log_ops[]; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [GFS2 Patch] GFS2: Eliminate gfs2_rg_lops 2013-05-21 14:54 ` [Cluster-devel] [GFS2 Patch] GFS2: Eliminate gfs2_rg_lops Bob Peterson @ 2013-05-22 10:40 ` Steven Whitehouse 0 siblings, 0 replies; 2+ messages in thread From: Steven Whitehouse @ 2013-05-22 10:40 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, Added to the -nmw tree. Thanks, Steve. On Tue, 2013-05-21 at 10:54 -0400, Bob Peterson wrote: > Hi, > > With recent changes to the transactions, it appears that we > are no longer using the "log ops" for resource groups. Since the > log commit code processes the array of log ops, eliminating this > should be marginally better for performance. Therefore this patch > eliminates it. > > Regards, > > Bob Peterson > Red Hat File Systems > > Signed-off-by: Bob Peterson <rpeterso@redhat.com> > --- > fs/gfs2/lops.c | 5 ----- > fs/gfs2/lops.h | 1 - > 2 files changed, 6 deletions(-) > > diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c > index e069041..0457768 100644 > --- a/fs/gfs2/lops.c > +++ b/fs/gfs2/lops.c > @@ -850,10 +850,6 @@ const struct gfs2_log_operations gfs2_revoke_lops = { > .lo_name = "revoke", > }; > > -const struct gfs2_log_operations gfs2_rg_lops = { > - .lo_name = "rg", > -}; > - > const struct gfs2_log_operations gfs2_databuf_lops = { > .lo_before_commit = databuf_lo_before_commit, > .lo_after_commit = databuf_lo_after_commit, > @@ -865,7 +861,6 @@ const struct gfs2_log_operations gfs2_databuf_lops = { > const struct gfs2_log_operations *gfs2_log_ops[] = { > &gfs2_databuf_lops, > &gfs2_buf_lops, > - &gfs2_rg_lops, > &gfs2_revoke_lops, > NULL, > }; > diff --git a/fs/gfs2/lops.h b/fs/gfs2/lops.h > index 87e062e..9ca2e64 100644 > --- a/fs/gfs2/lops.h > +++ b/fs/gfs2/lops.h > @@ -23,7 +23,6 @@ > extern const struct gfs2_log_operations gfs2_glock_lops; > extern const struct gfs2_log_operations gfs2_buf_lops; > extern const struct gfs2_log_operations gfs2_revoke_lops; > -extern const struct gfs2_log_operations gfs2_rg_lops; > extern const struct gfs2_log_operations gfs2_databuf_lops; > > extern const struct gfs2_log_operations *gfs2_log_ops[]; > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-22 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <871458792.21418809.1369147754601.JavaMail.root@redhat.com>
2013-05-21 14:54 ` [Cluster-devel] [GFS2 Patch] GFS2: Eliminate gfs2_rg_lops Bob Peterson
2013-05-22 10:40 ` Steven Whitehouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).