From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Make sure we don't miss any delayed withdraws
Date: Tue, 1 Sep 2020 10:11:17 -0400 (EDT) [thread overview]
Message-ID: <1627290349.15019228.1598969477058.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200829092656.1173430-1-agruenba@redhat.com>
----- Original Message -----
> Commit ca399c96e96e changes gfs2_log_flush to not withdraw the
> filesystem while holding the log flush lock, but it fails to check if
> the filesystem needs to be withdrawn once the log flush lock has been
> released. Likewise, commit f05b86db314d depends on gfs2_log_flush to
> trigger for delayed withdraws. Add that and clean up the code flow
> somewhat.
>
> In gfs2_put_super, add a check for delayed withdraws that have been
> missed to prevent these kinds of bugs in the future.
>
> Fixes: ca399c96e96e ("gfs2: flesh out delayed withdraw for gfs2_log_flush")
> Fixes: f05b86db314d ("gfs2: Prepare to withdraw as soon as an IO error occurs
> in log write")
> Cc: stable at vger.kernel.org # v5.7+
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
Looks good.
Reviewed-by: Bob Peterson <rpeterso@redhat.com>
Bob Peterson
prev parent reply other threads:[~2020-09-01 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 9:26 [Cluster-devel] [PATCH] gfs2: Make sure we don't miss any delayed withdraws Andreas Gruenbacher
2020-08-29 21:59 ` Sasha Levin
2020-09-01 14:11 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1627290349.15019228.1598969477058.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).