From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Tue, 1 Sep 2020 10:11:17 -0400 (EDT) Subject: [Cluster-devel] [PATCH] gfs2: Make sure we don't miss any delayed withdraws In-Reply-To: <20200829092656.1173430-1-agruenba@redhat.com> References: <20200829092656.1173430-1-agruenba@redhat.com> Message-ID: <1627290349.15019228.1598969477058.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > Commit ca399c96e96e changes gfs2_log_flush to not withdraw the > filesystem while holding the log flush lock, but it fails to check if > the filesystem needs to be withdrawn once the log flush lock has been > released. Likewise, commit f05b86db314d depends on gfs2_log_flush to > trigger for delayed withdraws. Add that and clean up the code flow > somewhat. > > In gfs2_put_super, add a check for delayed withdraws that have been > missed to prevent these kinds of bugs in the future. > > Fixes: ca399c96e96e ("gfs2: flesh out delayed withdraw for gfs2_log_flush") > Fixes: f05b86db314d ("gfs2: Prepare to withdraw as soon as an IO error occurs > in log write") > Cc: stable at vger.kernel.org # v5.7+ > Signed-off-by: Andreas Gruenbacher > --- Looks good. Reviewed-by: Bob Peterson Bob Peterson