From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Mon, 8 Oct 2018 16:10:58 -0400 (EDT) Subject: [Cluster-devel] [PATCH] gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd In-Reply-To: <20181008115624.18173-1-anprice@redhat.com> References: <20181008115624.18173-1-anprice@redhat.com> Message-ID: <1685328847.19268680.1539029458489.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > When alloc_percpu() fails, sdp gets freed but sb->s_fs_info still points > to the same address. Move the assignment after that error check so that > s_fs_info can only point to a valid sdp or NULL, which is checked for > later in the error path, in gfs2_kill_super(). > > Reported-by: syzbot+dcb8b3587445007f5808 at syzkaller.appspotmail.com > Signed-off-by: Andrew Price > --- Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=4c62bd9cea7bcf10292f7e4c57a2bca332942697 Regards, Bob Peterson Red Hat File Systems