* [Cluster-devel] gfs2: fix quota updates on block boundaries
@ 2015-06-04 10:58 Dan Carpenter
2015-06-04 16:26 ` Abhijith Das
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-06-04 10:58 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hello Abhi Das,
The patch 39a725803bee: "gfs2: fix quota updates on block boundaries"
from Jun 2, 2015, leads to the following static checker warning:
fs/gfs2/quota.c:801 gfs2_adjust_quota()
warn: unsigned '()' is never less than zero.
fs/gfs2/quota.c
798 loc -= sizeof(q); /* gfs2_internal_read would've advanced the loc ptr */
799 err = -EIO;
800 be64_add_cpu(&q.qu_value, change);
801 if (be64_to_cpu(q.qu_value) < 0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Never true.
802 q.qu_value = 0; /* Never go negative on quota usage */
803 qd->qd_qb.qb_value = q.qu_value;
804 if (fdq) {
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* [Cluster-devel] gfs2: fix quota updates on block boundaries
2015-06-04 10:58 [Cluster-devel] gfs2: fix quota updates on block boundaries Dan Carpenter
@ 2015-06-04 16:26 ` Abhijith Das
0 siblings, 0 replies; 2+ messages in thread
From: Abhijith Das @ 2015-06-04 16:26 UTC (permalink / raw)
To: cluster-devel.redhat.com
----- Original Message -----
> From: "Dan Carpenter" <dan.carpenter@oracle.com>
> To: adas at redhat.com
> Cc: cluster-devel at redhat.com
> Sent: Thursday, June 4, 2015 5:58:16 AM
> Subject: re: gfs2: fix quota updates on block boundaries
>
> Hello Abhi Das,
>
> The patch 39a725803bee: "gfs2: fix quota updates on block boundaries"
> from Jun 2, 2015, leads to the following static checker warning:
>
> fs/gfs2/quota.c:801 gfs2_adjust_quota()
> warn: unsigned '()' is never less than zero.
>
> fs/gfs2/quota.c
> 798 loc -= sizeof(q); /* gfs2_internal_read would've advanced the
> loc ptr */
> 799 err = -EIO;
> 800 be64_add_cpu(&q.qu_value, change);
> 801 if (be64_to_cpu(q.qu_value) < 0)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Never true.
>
> 802 q.qu_value = 0; /* Never go negative on quota usage
> */
> 803 qd->qd_qb.qb_value = q.qu_value;
> 804 if (fdq) {
>
> regards,
> dan carpenter
>
Hi Dan,
Thanks for spotting that. Looks like the if condition is missing a (s64) cast.
I'll post another patch to address this.
Cheers!
--Abhi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-04 16:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-04 10:58 [Cluster-devel] gfs2: fix quota updates on block boundaries Dan Carpenter
2015-06-04 16:26 ` Abhijith Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).