* [Cluster-devel] [GFS2 PATCH] Revert "GFS2: Re-add a call to log_flush_wait when flushing the journal"
[not found] <1588376288.49232678.1611336180266.JavaMail.zimbra@redhat.com>
@ 2021-01-22 17:23 ` Bob Peterson
0 siblings, 0 replies; only message in thread
From: Bob Peterson @ 2021-01-22 17:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This reverts commit 428fd95d859b24fea448380fa21ad6d841b34241.
Patch 428fd95d85b2 added a call to log_flush_wait to function
gfs2_log_flush. Then gfs2_log_flush calls log_write_header which submits
a write request with the REQ_PREFLUSH flag which also forces it to wait.
This patch removes the unnecessary call to log_flush_wait.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
fs/gfs2/log.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 2e9314091c81..41d13f19d1b4 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -1004,7 +1004,6 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl, u32 flags)
goto out_withdraw;
if (sdp->sd_log_head != sdp->sd_log_flush_head) {
- log_flush_wait(sdp);
log_write_header(sdp, flags);
} else if (sdp->sd_log_tail != current_tail(sdp) && !sdp->sd_log_idle){
atomic_dec(&sdp->sd_log_blks_free); /* Adjust for unreserved buffer */
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-22 17:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1588376288.49232678.1611336180266.JavaMail.zimbra@redhat.com>
2021-01-22 17:23 ` [Cluster-devel] [GFS2 PATCH] Revert "GFS2: Re-add a call to log_flush_wait when flushing the journal" Bob Peterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).