From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Wed, 8 Aug 2018 14:52:03 -0400 (EDT) Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor In-Reply-To: <17883672.769837.1533754253446.JavaMail.zimbra@redhat.com> Message-ID: <183182471.770089.1533754323408.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Before this patch, function foreach_descriptor repeatedly called function gfs2_replay_incr_blk which just incremented the value while decrementing another, and checked for wrap. This is a waste of time. This patch just adds the value and adjusts it if a wrap occurred. Signed-off-by: Bob Peterson --- fs/gfs2/recovery.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c index 0f501f938d1c..6c6b19263b82 100644 --- a/fs/gfs2/recovery.c +++ b/fs/gfs2/recovery.c @@ -354,8 +354,9 @@ static int foreach_descriptor(struct gfs2_jdesc *jd, unsigned int start, return error; } - while (length--) - gfs2_replay_incr_blk(jd, &start); + start += length; + if (start >= jd->jd_blocks) + start -= jd->jd_blocks; brelse(bh); }