From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v4 23/27] gfs2: clean up some filemap_* calls
Date: Wed, 10 May 2017 12:18:51 -0400 (EDT) [thread overview]
Message-ID: <1840580824.6421109.1494433131277.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170509154930.29524-24-jlayton@redhat.com>
----- Original Message -----
| In some places, it's trying to reset the mapping error after calling
| filemap_fdatawait. That's no longer required. Also, turn several
| filemap_fdatawrite+filemap_fdatawait calls into filemap_write_and_wait.
| That will at least return writeback errors that occur during the write
| phase.
|
| Signed-off-by: Jeff Layton <jlayton@redhat.com>
| ---
Hi Jeff,
This version looks better. ACK.
Regards,
Bob Peterson
Red Hat File Systems
next prev parent reply other threads:[~2017-05-10 16:18 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 15:49 [Cluster-devel] [PATCH v4 00/27] fs: introduce new writeback error reporting and convert existing API as a wrapper around it Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 01/27] fs: remove unneeded forward definition of mm_struct from fs.h Jeff Layton
2017-05-10 11:04 ` Jan Kara
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 02/27] mm: drop "wait" parameter from write_one_page Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 03/27] mm: fix mapping_set_error call in me_pagecache_dirty Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 04/27] buffer: use mapping_set_error instead of setting the flag Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 05/27] btrfs: btrfs_wait_tree_block_writeback can be void return Jeff Layton
2017-05-10 11:09 ` Jan Kara
2017-05-19 4:07 ` Liu Bo
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 06/27] fs: check for writeback errors after syncing out buffers in generic_file_fsync Jeff Layton
2017-05-10 12:48 ` Matthew Wilcox
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 07/27] orangefs: don't call filemap_write_and_wait from fsync Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 08/27] dax: set errors in mapping when writeback fails Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 09/27] nilfs2: set the mapping error when calling SetPageError on writeback Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 10/27] 9p: set mapping error when writeback fails in launder_page Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 11/27] fuse: set mapping error in writepage_locked when it fails Jeff Layton
2017-05-10 11:13 ` Jan Kara
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 12/27] cifs: set mapping error when page writeback fails in writepage or launder_pages Jeff Layton
2017-05-10 11:14 ` Jan Kara
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 13/27] lib: add errseq_t type and infrastructure for handling it Jeff Layton
2017-05-09 22:03 ` NeilBrown
2017-05-10 11:29 ` Jeff Layton
2017-05-10 11:34 ` Jan Kara
2017-05-10 14:18 ` Matthew Wilcox
2017-05-10 14:56 ` Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 14/27] fs: new infrastructure for writeback error handling and reporting Jeff Layton
2017-05-10 11:48 ` Jan Kara
2017-05-10 12:19 ` Jeff Layton
2017-05-10 13:46 ` Jan Kara
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 15/27] fs: retrofit old error reporting API onto new infrastructure Jeff Layton
2017-05-15 10:42 ` Jan Kara
2017-05-15 17:58 ` Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 16/27] fs: adapt sync_file_range to new reporting infrastructure Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 17/27] mm: remove AS_EIO and AS_ENOSPC flags Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 18/27] mm: don't TestClearPageError in __filemap_fdatawait_range Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 19/27] buffer: set errors in mapping at the time that the error occurs Jeff Layton
2017-05-15 11:53 ` Jan Kara
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 20/27] cifs: cleanup writeback handling errors and comments Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 21/27] mm: clean up error handling in write_one_page Jeff Layton
2017-05-15 12:01 ` Jan Kara
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 22/27] jbd2: don't reset error in journal_finish_inode_data_buffers Jeff Layton
2017-05-15 11:58 ` Jan Kara
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 23/27] gfs2: clean up some filemap_* calls Jeff Layton
2017-05-10 16:18 ` Bob Peterson [this message]
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 24/27][RFC] nfs: convert to new errseq_t based error tracking for writeback errors Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 25/27] Documentation: flesh out the section in vfs.txt on storing and reporting " Jeff Layton
2017-05-09 16:24 ` Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 26/27] mm: flesh out comments over mapping_set_error Jeff Layton
2017-05-09 15:49 ` [Cluster-devel] [PATCH v4 27/27] mm: clean up comments in me_pagecache_dirty Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1840580824.6421109.1494433131277.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).