From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Fri, 4 Oct 2019 11:49:14 -0400 (EDT) Subject: [Cluster-devel] [PATCH] gfs2: removed unnecessary semicolon In-Reply-To: <20191002174631.15919-1-aliasgar.surti500@gmail.com> References: <20191002174631.15919-1-aliasgar.surti500@gmail.com> Message-ID: <1944905967.4863703.1570204154537.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > From: Aliasgar Surti > > There is use of unnecessary semicolon after switch case. > Removed the semicolon. > > Signed-off-by: Aliasgar Surti > --- > fs/gfs2/recovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c > index c529f8749a89..f4aa8551277b 100644 > --- a/fs/gfs2/recovery.c > +++ b/fs/gfs2/recovery.c > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work) > > default: > goto fail; > - }; > + } > > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED, > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh); > -- > 2.17.1 Hi, Thanks for the patch. I did a quick search and found two more: glops.c- break; glops.c: }; inode.c- goto out_gunlock; inode.c: }; Do you want to include those in your patch and re-submit it or should I cook up a second patch? Regards, Bob Peterson Red Hat File Systems