cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/daemon cpg.c
Date: 7 Jul 2006 15:13:14 -0000	[thread overview]
Message-ID: <20060707151314.29543.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	teigland at sourceware.org	2006-07-07 15:13:14

Modified files:
	group/daemon   : cpg.c 

Log message:
	complain and ignore a cpg confchg reason we don't understand

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/daemon/cpg.c.diff?cvsroot=cluster&r1=1.29&r2=1.30

--- cluster/group/daemon/cpg.c	2006/06/30 15:29:17	1.29
+++ cluster/group/daemon/cpg.c	2006/07/07 15:13:13	1.30
@@ -289,10 +289,19 @@
 		log_group(g, "confchg removed node %d reason %d",
 			  saved_left[i].nodeid, saved_left[i].reason);
 
-		if (saved_left[i].reason == CPG_REASON_LEAVE)
+		switch (saved_left[i].reason) {
+		case CPG_REASON_LEAVE:
 			process_node_leave(g, saved_left[i].nodeid);
-		else
+			break;
+		case CPG_REASON_NODEDOWN:
+		case CPG_REASON_PROCDOWN:
 			process_node_down(g, saved_left[i].nodeid);
+			break;
+		default:
+			log_error(g, "unknown leave reason %d node %d",
+				  saved_left[i].reason,
+				  saved_joined[i].nodeid);
+		}
 	}
 }
 
@@ -343,26 +352,14 @@
 	saved_name.length = group_name->length;
 	memcpy(&saved_name.value, &group_name->value, group_name->length);
 
-	/* fprintf(stderr, "CONFCHG LEFT: "); */
-	for (i = 0; i < left_list_entries; i++) {
+	for (i = 0; i < left_list_entries; i++)
 		saved_left[i] = left_list[i];
-		/* fprintf(stderr, "%d ", left_list[i].nodeid); */
-	}
-	/* fprintf(stderr, "\n"); */
 
-	/* fprintf(stderr, "CONFCHG JOIN: "); */
-	for (i = 0; i < joined_list_entries; i++) {
+	for (i = 0; i < joined_list_entries; i++)
 		saved_joined[i] = joined_list[i];
-		/* fprintf(stderr, "%d ", joined_list[i].nodeid); */
-	}
-	/* fprintf(stderr, "\n"); */
 
-	/* fprintf(stderr, "CONFCHG MEMB: "); */
-	for (i = 0; i < member_list_entries; i++) {
+	for (i = 0; i < member_list_entries; i++)
 		saved_member[i] = member_list[i];
-		/* fprintf(stderr, "%d ", member_list[i].nodeid); */
-	}
-	/* fprintf(stderr, "\n"); */
 
 	got_confchg = 1;
 }



             reply	other threads:[~2006-07-07 15:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-07 15:13 teigland [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-10-13 15:57 [Cluster-devel] cluster/group/daemon cpg.c teigland
2006-09-28 19:26 teigland
2006-09-08 23:14 teigland
2006-06-22 22:24 teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060707151314.29543.qmail@sourceware.org \
    --to=teigland@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).