From: kupcevic@sourceware.org <kupcevic@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/ricci docs/storage_api.html modules/stor ...
Date: 12 Jul 2006 16:52:57 -0000 [thread overview]
Message-ID: <20060712165257.19094.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Changes by: kupcevic at sourceware.org 2006-07-12 16:52:56
Modified files:
ricci/docs : storage_api.html
ricci/modules/storage: LVM.cpp
Added files:
ricci/modules/storage: ClusterNotQuorateError.h
Log message:
storage module: prevent lvm tools to hang due to lack of cluster quorum
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/docs/storage_api.html.diff?cvsroot=cluster&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/ClusterNotQuorateError.h.diff?cvsroot=cluster&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/LVM.cpp.diff?cvsroot=cluster&r1=1.3&r2=1.4
--- conga/ricci/docs/storage_api.html 2006/06/28 20:09:08 1.3
+++ conga/ricci/docs/storage_api.html 2006/07/12 16:52:56 1.4
@@ -5,7 +5,7 @@
<TITLE>Storage Module</TITLE>
<META NAME="GENERATOR" CONTENT="OpenOffice.org 1.1.2 (Linux)">
<META NAME="CREATED" CONTENT="20060410;13011800">
- <META NAME="CHANGED" CONTENT="20060626;19014000">
+ <META NAME="CHANGED" CONTENT="20060712;12410300">
</HEAD>
<BODY LANG="en-US" DIR="LTR">
<P>Storage module manages all aspects of storage. Supports partition
@@ -73,6 +73,11 @@
start clvmd: <BR>1. lvm2-cluster needs to be installed<BR>2. cluster
infrastructure needs to be started<BR>3. clvmd should be started
(service clvmd start)</P>
+ <LI><P>5 ??? cluster not quorate<BR>LVM is configured to use cluster
+ locking mechanism, but cluster is not quorate. That would cause LVM
+ operations to hang until quorum is regained. User should make
+ cluster quorate before continuing.
+ </P>
</UL>
<P><BR><BR>
</P>
/cvs/cluster/conga/ricci/modules/storage/ClusterNotQuorateError.h,v --> standard output
revision 1.1
--- conga/ricci/modules/storage/ClusterNotQuorateError.h
+++ - 2006-07-12 16:52:56.900818000 +0000
@@ -0,0 +1,41 @@
+/*
+ Copyright Red Hat, Inc. 2006
+
+ This program is free software; you can redistribute it and/or modify it
+ under the terms of the GNU General Public License as published by the
+ Free Software Foundation; either version 2, or (at your option) any
+ later version.
+
+ This program is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; see the file COPYING. If not, write to the
+ Free Software Foundation, Inc., 675 Mass Ave, Cambridge,
+ MA 02139, USA.
+*/
+/*
+ * Author: Stanko Kupcevic <kupcevic@redhat.com>
+ */
+
+
+#ifndef ClusterNotQuorateError_h
+#define ClusterNotQuorateError_h
+
+#include "Except.h"
+
+
+class ClusterNotQuorateError : public Except
+{
+ public:
+ ClusterNotQuorateError()
+ : Except(5, std::string("Quorum required, but cluster not quorate")) {}
+ virtual ~ClusterNotQuorateError()
+ {}
+
+};
+
+
+#endif // ClusterNotQuorateError_h
--- conga/ricci/modules/storage/LVM.cpp 2006/06/28 20:09:08 1.3
+++ conga/ricci/modules/storage/LVM.cpp 2006/07/12 16:52:56 1.4
@@ -28,6 +28,7 @@
#include "LV.h"
#include "defines.h"
#include "ClvmdError.h"
+#include "ClusterNotQuorateError.h"
#include <vector>
@@ -690,10 +691,20 @@
LVM::check_locking()
{
if (get_locking_type() == "2") {
- // try to start clvmd, if not running
+ // check if quorate
string out, err;
int status;
vector<string> args;
+ args.push_back("quorum");
+ if (utils::execute("/sbin/magma_tool", args, out, err, status))
+ throw string("execute failed");
+ if (status)
+ throw string("cluster tools: magma_tool errored");
+ if (out.find("Quorate") == out.npos)
+ throw ClusterNotQuorateError();
+
+ // try to start clvmd, if not running
+ args.clear();
args.push_back("clvmd");
args.push_back("start");
if (utils::execute("/sbin/service", args, out, err, status))
next reply other threads:[~2006-07-12 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 16:52 kupcevic [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-16 20:26 [Cluster-devel] conga/ricci docs/storage_api.html modules/stor kupcevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712165257.19094.qmail@sourceware.org \
--to=kupcevic@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).