From: lhh@sourceware.org <lhh@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/rgmanager/src/resources fs.sh
Date: 26 Jul 2006 15:31:22 -0000 [thread overview]
Message-ID: <20060726153122.4313.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4U4
Changes by: lhh at sourceware.org 2006-07-26 15:31:20
Modified files:
rgmanager/src/resources: fs.sh
Log message:
Change ordering in fs.sh to avoid possibility of a lock being reclaimed on the fs we're trying to unmount
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/resources/fs.sh.diff?cvsroot=cluster&only_with_tag=RHEL4U4&r1=1.4.2.14&r2=1.4.2.14.2.1
--- cluster/rgmanager/src/resources/fs.sh 2006/06/16 19:57:52 1.4.2.14
+++ cluster/rgmanager/src/resources/fs.sh 2006/07/26 15:31:20 1.4.2.14.2.1
@@ -1061,7 +1061,8 @@
typeset -i ret_val=0
typeset -i try=1
typeset -i max_tries=3 # how many times to try umount
- typeset -i sleep_time=2 # time between each umount failure
+ typeset -i sleep_time=5 # time between each umount failure
+ typeset -i nfslock_reclaim=0
typeset done=""
typeset umount_failed=""
typeset force_umount=""
@@ -1157,11 +1158,8 @@
mkdir -p $mp/.clumanager/statd
# Copy out the notify list; our
# IPs are already torn down
- if notify_list_store $mp/.clumanager/statd
- then
- notify_list_broadcast \
- $mp/.clumanager/statd
- fi
+ notify_list_store $mp/.clumanager/statd
+ nfslock_reclaim=1
fi
fi
fi
@@ -1186,6 +1184,11 @@
fi
done # while
+ if [ $nfslock_reclaim -eq 1 ]; then
+ # If we have this flag set, do a full reclaim broadcast
+ notify_list_broadcast $mp/.clumanager/statd
+ fi
+
if [ -n "$umount_failed" ]; then
ocf_log err "'umount $mp' failed, error=$ret_val"
next reply other threads:[~2006-07-26 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-26 15:31 lhh [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-13 18:28 [Cluster-devel] cluster/rgmanager/src/resources fs.sh lhh
2007-02-13 15:51 lhh
2007-02-13 15:52 lhh
2007-02-13 15:55 lhh
2007-02-13 15:56 lhh
2008-01-15 22:34 lhh
2008-01-15 22:44 lhh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726153122.4313.qmail@sourceware.org \
--to=lhh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).