cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: wcheng@sourceware.org <wcheng@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/gfs super.c
Date: 2 Aug 2006 01:37:17 -0000	[thread overview]
Message-ID: <20060802013717.1647.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	wcheng at sourceware.org	2006-08-02 01:37:17

Modified files:
	gfs-kernel/src/gfs: super.c 

Log message:
	Bugzilla 199984: Increasing gt_statfs_slots tunable could significantly
	boost gfs "df" performance; e.g. set it to 128 from current default (64)
	could cut the "df" wall time in half with larger filesystem size. However,
	the kmalloc call within stat_gfs_async() has the possibility to fail due
	to increased gt_statfs_slots. There is really no need for this array to
	be on a piece of contiguous memory. Switch to vmalloc().

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/super.c.diff?cvsroot=cluster&r1=1.19&r2=1.20

--- cluster/gfs-kernel/src/gfs/super.c	2006/07/11 17:29:24	1.19
+++ cluster/gfs-kernel/src/gfs/super.c	2006/08/02 01:37:16	1.20
@@ -840,7 +840,7 @@
 
 	memset(sg, 0, sizeof(struct gfs_stat_gfs));
 
-	gha = kmalloc(slots * sizeof(struct gfs_holder), GFP_KERNEL);
+	gha = vmalloc(slots * sizeof(struct gfs_holder));
 	if (!gha)
 		return -ENOMEM;
 	memset(gha, 0, slots * sizeof(struct gfs_holder));
@@ -884,7 +884,7 @@
 		yield();
 	}
 
-	kfree(gha);
+	vfree(gha);
 
 	return error;
 }



             reply	other threads:[~2006-08-02  1:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-02  1:37 wcheng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-02-06 22:08 [Cluster-devel] cluster/gfs-kernel/src/gfs super.c wcheng
2006-09-20  4:45 wcheng
2006-08-09 20:28 rpeterso
2006-08-02  1:28 wcheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060802013717.1647.qmail@sourceware.org \
    --to=wcheng@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).