From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/gfs_controld plock.c
Date: 14 Aug 2006 20:15:25 -0000 [thread overview]
Message-ID: <20060814201525.15457.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: teigland at sourceware.org 2006-08-14 20:15:25
Modified files:
group/gfs_controld: plock.c
Log message:
remove a couple log_error's
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/gfs_controld/plock.c.diff?cvsroot=cluster&r1=1.12&r2=1.13
--- cluster/group/gfs_controld/plock.c 2006/08/09 19:35:26 1.12
+++ cluster/group/gfs_controld/plock.c 2006/08/14 20:15:25 1.13
@@ -1086,7 +1086,8 @@
goto out_close;
}
if (rv != SA_AIS_OK) {
- log_error("unlink ckpt close error %d %s", rv, mg->name);
+ /* should this be log_error */
+ log_group(mg, "unlink ckpt close error %d", rv);
ret = -1;
}
@@ -1333,7 +1334,10 @@
iov.readSize);
section_len = iov.readSize;
- if (!section_len || section_len % sizeof(struct pack_plock)) {
+ if (!section_len)
+ continue;
+
+ if (section_len % sizeof(struct pack_plock)) {
log_error("retrieve_plocks: bad section len %d %s",
section_len, mg->name);
continue;
next reply other threads:[~2006-08-14 20:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 20:15 teigland [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-21 20:21 [Cluster-devel] cluster/group/gfs_controld plock.c teigland
2008-01-21 20:19 teigland
2008-01-21 20:17 teigland
2007-11-30 16:20 teigland
2007-11-29 21:27 teigland
2007-06-08 21:31 teigland
2007-06-08 21:30 teigland
2006-11-20 21:29 teigland
2006-11-20 21:29 teigland
2006-11-20 21:28 teigland
2006-11-20 18:13 teigland
2006-11-20 18:12 teigland
2006-11-20 18:10 teigland
2006-11-03 15:33 teigland
2006-10-09 21:51 teigland
2006-08-17 19:39 teigland
2006-08-16 19:30 teigland
2006-08-16 17:05 teigland
2006-08-15 22:21 rpeterso
2006-08-08 19:37 teigland
2006-08-08 18:43 teigland
2006-08-02 19:23 teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814201525.15457.qmail@sourceware.org \
--to=teigland@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).