* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-08-31 10:11 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-08-31 10:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: pcaulfield at sourceware.org 2006-08-31 10:11:53
Modified files:
cman/lib : libcman.c
Log message:
make cman_dispatch(, CMAN_DISPATCH_ALL) do what it's supposed to do.
Thanks to Mikhail A Zelikov for spooting this.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.3.2.6&r2=1.3.2.7
--- cluster/cman/lib/libcman.c 2006/04/26 08:54:33 1.3.2.6
+++ cluster/cman/lib/libcman.c 2006/08/31 10:11:53 1.3.2.7
@@ -201,7 +201,7 @@
}
while ( flags & CMAN_DISPATCH_ALL &&
- (len < 0 && errno == EAGAIN) );
+ !(len < 0 && errno == EAGAIN) );
return len;
}
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2008-01-07 18:53 lhh
0 siblings, 0 replies; 16+ messages in thread
From: lhh @ 2008-01-07 18:53 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: lhh at sourceware.org 2008-01-07 18:53:15
Modified files:
cman/lib : libcman.c
Log message:
Correct signed vs. unsigned comparison on sparc64
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.40&r2=1.41
--- cluster/cman/lib/libcman.c 2007/12/05 14:28:58 1.40
+++ cluster/cman/lib/libcman.c 2008/01/07 18:53:14 1.41
@@ -240,7 +240,7 @@
iovlen--;
}
- if (iovlen <=0 )
+ if ((ssize_t)iovlen <=0 )
break;
iovptr->iov_base += len;
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2007-09-19 19:15 cfeist
0 siblings, 0 replies; 16+ messages in thread
From: cfeist @ 2007-09-19 19:15 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL51
Changes by: cfeist at sourceware.org 2007-09-19 19:15:16
Modified files:
cman/lib : libcman.c
Log message:
Fixes #294351 - qdisk does not run on multipathed /dev/mapper devices
Cman now allows devices to be greater than 16 characters
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=RHEL51&r1=1.30.2.3&r2=1.30.2.3.2.1
--- cluster/cman/lib/libcman.c 2007/01/05 10:31:33 1.30.2.3
+++ cluster/cman/lib/libcman.c 2007/09/19 19:15:16 1.30.2.3.2.1
@@ -994,7 +994,7 @@
char buf[strlen(name)+1 + sizeof(int)];
VALIDATE_HANDLE(h);
- if (strlen(name) > MAX_CLUSTER_NAME_LEN)
+ if (strlen(name) > MAX_CLUSTER_MEMBER_NAME_LEN)
{
errno = EINVAL;
return -1;
^ permalink raw reply [flat|nested] 16+ messages in thread* [Cluster-devel] cluster/cman/lib libcman.c
@ 2007-09-18 16:01 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2007-09-18 16:01 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: pcaulfield at sourceware.org 2007-09-18 16:01:00
Modified files:
cman/lib : libcman.c
Log message:
Check quorum device name length against the right size.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.30.2.5&r2=1.30.2.6
--- cluster/cman/lib/libcman.c 2007/09/17 13:48:15 1.30.2.5
+++ cluster/cman/lib/libcman.c 2007/09/18 16:00:56 1.30.2.6
@@ -1010,7 +1010,7 @@
char buf[strlen(name)+1 + sizeof(int)];
VALIDATE_HANDLE(h);
- if (strlen(name) > MAX_CLUSTER_NAME_LEN)
+ if (strlen(name) > MAX_CLUSTER_MEMBER_NAME_LEN)
{
errno = EINVAL;
return -1;
^ permalink raw reply [flat|nested] 16+ messages in thread* [Cluster-devel] cluster/cman/lib libcman.c
@ 2007-09-18 15:34 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2007-09-18 15:34 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2007-09-18 15:34:41
Modified files:
cman/lib : libcman.c
Log message:
check quorum device name length against the right size.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.36&r2=1.37
--- cluster/cman/lib/libcman.c 2007/08/28 13:14:10 1.36
+++ cluster/cman/lib/libcman.c 2007/09/18 15:34:41 1.37
@@ -1010,7 +1010,7 @@
char buf[strlen(name)+1 + sizeof(int)];
VALIDATE_HANDLE(h);
- if (strlen(name) > MAX_CLUSTER_NAME_LEN)
+ if (strlen(name) > MAX_CLUSTER_MEMBER_NAME_LEN)
{
errno = EINVAL;
return -1;
^ permalink raw reply [flat|nested] 16+ messages in thread* [Cluster-devel] cluster/cman/lib libcman.c
@ 2007-02-23 9:51 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2007-02-23 9:51 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: STABLE
Changes by: pcaulfield at sourceware.org 2007-02-23 09:51:23
Modified files:
cman/lib : libcman.c
Log message:
Copy RHEL4 CMAN_DISPATCH_ALL fix over
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=STABLE&r1=1.3.6.1.2.6&r2=1.3.6.1.2.7
--- cluster/cman/lib/libcman.c 2007/02/07 15:25:04 1.3.6.1.2.6
+++ cluster/cman/lib/libcman.c 2007/02/23 09:51:23 1.3.6.1.2.7
@@ -201,7 +201,7 @@
}
while ( flags & CMAN_DISPATCH_ALL &&
- (len < 0 && errno == EAGAIN) );
+ !(len < 0 && errno == EAGAIN) );
return len;
}
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2007-01-05 10:31 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2007-01-05 10:31 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: pcaulfield at sourceware.org 2007-01-05 10:31:34
Modified files:
cman/lib : libcman.c
Log message:
Send correct length of quorum device name sent to cman.
Thanks to simone.gotti at email.it for the patch
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.30.2.2&r2=1.30.2.3
--- cluster/cman/lib/libcman.c 2006/12/19 10:55:57 1.30.2.2
+++ cluster/cman/lib/libcman.c 2007/01/05 10:31:33 1.30.2.3
@@ -1002,7 +1002,7 @@
memcpy(buf, &votes, sizeof(int));
strcpy(buf+sizeof(int), name);
- return info_call(h, CMAN_CMD_REG_QUORUMDEV, buf, strlen(name)+sizeof(int), NULL, 0);
+ return info_call(h, CMAN_CMD_REG_QUORUMDEV, buf, strlen(name)+1+sizeof(int), NULL, 0);
}
int cman_unregister_quorum_device(cman_handle_t handle)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2007-01-05 10:30 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2007-01-05 10:30 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2007-01-05 10:30:54
Modified files:
cman/lib : libcman.c
Log message:
Send correct length of quorum device name sent to cman.
Thanks to simone.gotti at email.it for the patch
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.32&r2=1.33
--- cluster/cman/lib/libcman.c 2006/12/19 10:55:00 1.32
+++ cluster/cman/lib/libcman.c 2007/01/05 10:30:53 1.33
@@ -1002,7 +1002,7 @@
memcpy(buf, &votes, sizeof(int));
strcpy(buf+sizeof(int), name);
- return info_call(h, CMAN_CMD_REG_QUORUMDEV, buf, strlen(name)+sizeof(int), NULL, 0);
+ return info_call(h, CMAN_CMD_REG_QUORUMDEV, buf, strlen(name)+1+sizeof(int), NULL, 0);
}
int cman_unregister_quorum_device(cman_handle_t handle)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-12-19 10:55 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-12-19 10:55 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: pcaulfield at sourceware.org 2006-12-19 10:55:57
Modified files:
cman/lib : libcman.c
Log message:
Fix bug where cman_dispatch(CMAN_DISPATCH_ONE) could dispatch several
messages.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.30.2.1&r2=1.30.2.2
--- cluster/cman/lib/libcman.c 2006/12/01 14:23:03 1.30.2.1
+++ cluster/cman/lib/libcman.c 2006/12/19 10:55:57 1.30.2.2
@@ -486,7 +486,7 @@
h->saved_reply_msg = smsg->next;
len = smsg->msg->length;
free(smsg);
- if (res)
+ if (res || (flags & CMAN_DISPATCH_ONE))
break;
else
continue;
@@ -499,7 +499,7 @@
h->saved_data_msg = smsg->next;
len = smsg->msg->length;
free(smsg);
- if (res)
+ if (res || (flags & CMAN_DISPATCH_ONE))
break;
else
continue;
@@ -512,7 +512,7 @@
h->saved_event_msg = smsg->next;
len = smsg->msg->length;
free(smsg);
- if (res)
+ if (res || (flags & CMAN_DISPATCH_ONE))
break;
else
continue;
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-12-19 10:55 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-12-19 10:55 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2006-12-19 10:55:00
Modified files:
cman/lib : libcman.c
Log message:
Fix bug where cman_dispatch(CMAN_DISPATCH_ONE) could dispatch several
messages.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.31&r2=1.32
--- cluster/cman/lib/libcman.c 2006/12/01 13:46:57 1.31
+++ cluster/cman/lib/libcman.c 2006/12/19 10:55:00 1.32
@@ -486,7 +486,7 @@
h->saved_reply_msg = smsg->next;
len = smsg->msg->length;
free(smsg);
- if (res)
+ if (res || (flags & CMAN_DISPATCH_ONE))
break;
else
continue;
@@ -499,7 +499,7 @@
h->saved_data_msg = smsg->next;
len = smsg->msg->length;
free(smsg);
- if (res)
+ if (res || (flags & CMAN_DISPATCH_ONE))
break;
else
continue;
@@ -512,7 +512,7 @@
h->saved_event_msg = smsg->next;
len = smsg->msg->length;
free(smsg);
- if (res)
+ if (res || (flags & CMAN_DISPATCH_ONE))
break;
else
continue;
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-12-01 14:23 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-12-01 14:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL50
Changes by: pcaulfield at sourceware.org 2006-12-01 14:23:39
Modified files:
cman/lib : libcman.c
Log message:
That 'if' really should have been a 'while'.
If anyone can remember which bug this was supposed to fix, please pipe up :)
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=RHEL50&r1=1.30&r2=1.30.4.1
--- cluster/cman/lib/libcman.c 2006/10/25 12:23:46 1.30
+++ cluster/cman/lib/libcman.c 2006/12/01 14:23:39 1.30.4.1
@@ -233,7 +233,7 @@
return len;
byte_cnt += len;
- if (len >= iovptr->iov_len)
+ while (len >= iovptr->iov_len)
{
len -= iovptr->iov_len;
iovptr++;
^ permalink raw reply [flat|nested] 16+ messages in thread* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-12-01 14:23 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-12-01 14:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: pcaulfield at sourceware.org 2006-12-01 14:23:04
Modified files:
cman/lib : libcman.c
Log message:
That 'if' really should have been a 'while'.
If anyone can remember which bug this was supposed to fix, please pipe up :)
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.30&r2=1.30.2.1
--- cluster/cman/lib/libcman.c 2006/10/25 12:23:46 1.30
+++ cluster/cman/lib/libcman.c 2006/12/01 14:23:03 1.30.2.1
@@ -233,7 +233,7 @@
return len;
byte_cnt += len;
- if (len >= iovptr->iov_len)
+ while (len >= iovptr->iov_len)
{
len -= iovptr->iov_len;
iovptr++;
^ permalink raw reply [flat|nested] 16+ messages in thread* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-12-01 13:46 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-12-01 13:46 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2006-12-01 13:46:58
Modified files:
cman/lib : libcman.c
Log message:
That 'if' really should have been a 'while'.
If anyone can remember which bug this was supposed to fix, please pipe up :)
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.30&r2=1.31
--- cluster/cman/lib/libcman.c 2006/10/25 12:23:46 1.30
+++ cluster/cman/lib/libcman.c 2006/12/01 13:46:57 1.31
@@ -233,7 +233,7 @@
return len;
byte_cnt += len;
- if (len >= iovptr->iov_len)
+ while (len >= iovptr->iov_len)
{
len -= iovptr->iov_len;
iovptr++;
^ permalink raw reply [flat|nested] 16+ messages in thread* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-10-25 12:23 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-10-25 12:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2006-10-25 12:23:46
Modified files:
cman/lib : libcman.c
Log message:
fix CMAN_DISPATCH_ALL.
Patch from Mikhail A Zelikov which got inexplicably lost, sorry.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.29&r2=1.30
--- cluster/cman/lib/libcman.c 2006/10/16 15:52:15 1.29
+++ cluster/cman/lib/libcman.c 2006/10/25 12:23:46 1.30
@@ -569,7 +569,7 @@
break;
} while ( flags & CMAN_DISPATCH_ALL &&
- (len < 0 && errno == EAGAIN) );
+ !(len < 0 && errno == EAGAIN) );
return len;
}
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-10-16 15:52 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-10-16 15:52 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2006-10-16 15:52:15
Modified files:
cman/lib : libcman.c
Log message:
'while' should be an 'if'
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.28&r2=1.29
--- cluster/cman/lib/libcman.c 2006/10/05 07:48:33 1.28
+++ cluster/cman/lib/libcman.c 2006/10/16 15:52:15 1.29
@@ -233,7 +233,7 @@
return len;
byte_cnt += len;
- while (len >= iovptr->iov_len)
+ if (len >= iovptr->iov_len)
{
len -= iovptr->iov_len;
iovptr++;
^ permalink raw reply [flat|nested] 16+ messages in thread* [Cluster-devel] cluster/cman/lib libcman.c
@ 2006-08-24 10:40 pcaulfield
0 siblings, 0 replies; 16+ messages in thread
From: pcaulfield @ 2006-08-24 10:40 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: pcaulfield at sourceware.org 2006-08-24 10:40:57
Modified files:
cman/lib : libcman.c
Log message:
initialise confchg_callback
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/lib/libcman.c.diff?cvsroot=cluster&r1=1.26&r2=1.27
--- cluster/cman/lib/libcman.c 2006/08/17 13:22:39 1.26
+++ cluster/cman/lib/libcman.c 2006/08/24 10:40:57 1.27
@@ -300,6 +300,7 @@
h->private = private;
h->event_callback = NULL;
h->data_callback = NULL;
+ h->confchg_callback = NULL;
h->want_reply = 0;
h->saved_data_msg = NULL;
h->saved_event_msg = NULL;
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2008-01-07 18:53 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-31 10:11 [Cluster-devel] cluster/cman/lib libcman.c pcaulfield
-- strict thread matches above, loose matches on Subject: below --
2008-01-07 18:53 lhh
2007-09-19 19:15 cfeist
2007-09-18 16:01 pcaulfield
2007-09-18 15:34 pcaulfield
2007-02-23 9:51 pcaulfield
2007-01-05 10:31 pcaulfield
2007-01-05 10:30 pcaulfield
2006-12-19 10:55 pcaulfield
2006-12-19 10:55 pcaulfield
2006-12-01 14:23 pcaulfield
2006-12-01 14:23 pcaulfield
2006-12-01 13:46 pcaulfield
2006-10-25 12:23 pcaulfield
2006-10-16 15:52 pcaulfield
2006-08-24 10:40 pcaulfield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).