From mboxrd@z Thu Jan  1 00:00:00 1970
From: teigland@sourceware.org <teigland@sourceware.org>
Date: 13 Sep 2006 14:46:53 -0000
Subject: [Cluster-devel] cluster/cman-kernel/src sm_barrier.c
Message-ID: <20060913144653.27305.qmail@sourceware.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	teigland at sourceware.org	2006-09-13 14:46:52

Modified files:
	cman-kernel/src: sm_barrier.c 

Log message:
	process_startdone_barrier_new() can be called when sg->sevent is
	NULL, but we weren't checking for NULL and just deferencing the
	sev->flags which led to oops in bz 206212.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman-kernel/src/sm_barrier.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.1&r2=1.1.2.2

--- cluster/cman-kernel/src/Attic/sm_barrier.c	2005/06/06 03:50:34	1.1.2.1
+++ cluster/cman-kernel/src/Attic/sm_barrier.c	2006/09/13 14:46:52	1.1.2.2
@@ -141,6 +141,12 @@
 {
 	sm_sevent_t *sev = sg->sevent;
 
+	if (!sev) {
+		log_error(sg, "process_startdone_barrier_new: no sev %d",
+			  status);
+		return;
+	}
+
 	if (!test_and_clear_bit(SEFL_ALLOW_BARRIER, &sev->se_flags)) {
 		log_debug(sev->se_sg, "ignore barrier cb status %d", status);
 		return;