cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/daemon app.c
Date: 14 Sep 2006 20:56:55 -0000	[thread overview]
Message-ID: <20060914205655.17801.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	teigland at sourceware.org	2006-09-14 20:56:55

Modified files:
	group/daemon   : app.c 

Log message:
	Fixes a really stupid bug checked in yesterday that causes groupd
	to seg fault due to referencing a pointer that's not been set yet.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/daemon/app.c.diff?cvsroot=cluster&r1=1.43&r2=1.44

--- cluster/group/daemon/app.c	2006/09/12 21:57:05	1.43
+++ cluster/group/daemon/app.c	2006/09/14 20:56:55	1.44
@@ -723,10 +723,17 @@
 int do_startdone(char *name, int level, int event_nr)
 {
 	group_t *g;
-	event_t *ev = g->app->current_event;
+	event_t *ev;
 	char *state;
 
 	g = find_group_level(name, level);
+	if (!g) {
+		log_print("do_startdone: no group level %d name %s",
+			  level, name);
+		return -1;
+	}
+
+	ev = g->app->current_event;
 
 	state = ev ? ev_state_str(ev) : "no-event";
 



             reply	other threads:[~2006-09-14 20:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 20:56 teigland [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-10-16 15:52 [Cluster-devel] cluster/group/daemon app.c teigland
2006-10-12 14:25 teigland
2006-09-15 20:07 teigland
2006-08-31 18:20 teigland
2006-08-22 14:36 teigland
2006-08-14 21:01 teigland
2006-08-02 20:30 teigland
2006-07-19 19:45 teigland
2006-07-17 18:22 teigland
2006-07-17 17:06 rohara
2006-07-14 20:45 teigland
2006-07-16  7:51 ` Fabio Massimo Di Nitto
2006-07-17 17:08   ` Ryan O'Hara
2006-06-22 21:12 teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060914205655.17801.qmail@sourceware.org \
    --to=teigland@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).