From: kupcevic@sourceware.org <kupcevic@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/ricci/modules/storage FileMagic.cpp
Date: 23 Sep 2006 09:26:58 -0000 [thread overview]
Message-ID: <20060923092658.21495.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Changes by: kupcevic at sourceware.org 2006-09-23 09:26:58
Modified files:
ricci/modules/storage: FileMagic.cpp
Log message:
storage module: don't free libmagic's return buffer - double free
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/FileMagic.cpp.diff?cvsroot=cluster&r1=1.2&r2=1.3
--- conga/ricci/modules/storage/FileMagic.cpp 2006/09/14 17:57:56 1.2
+++ conga/ricci/modules/storage/FileMagic.cpp 2006/09/23 09:26:58 1.3
@@ -56,14 +56,14 @@
throw String("unknown data detected");
magic_close(cookie); cookie = 0;
- free((char*) buff); buff = 0;
+ // free((char*) buff); buff = 0;
return descr;
} catch ( ... ) {
if (cookie)
magic_close(cookie);
- if (buff)
- free((char*) buff);
+ // if (buff)
+ // free((char*) buff);
throw;
}
}
next reply other threads:[~2006-09-23 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 9:26 kupcevic [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-14 17:57 [Cluster-devel] conga/ricci/modules/storage FileMagic.cpp kupcevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060923092658.21495.qmail@sourceware.org \
--to=kupcevic@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).