* [Cluster-devel] cluster/cman-kernel/src sm_barrier.c
@ 2006-09-25 15:23 teigland
0 siblings, 0 replies; 2+ messages in thread
From: teigland @ 2006-09-25 15:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: STABLE
Changes by: teigland at sourceware.org 2006-09-25 15:23:01
Modified files:
cman-kernel/src: sm_barrier.c
Log message:
process_startdone_barrier_new() can be called when sg->sevent is
NULL, but we weren't checking for NULL and just deferencing the
sev->flags which led to oops in bz 206212.
(sync with RHEL4 branch)
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman-kernel/src/sm_barrier.c.diff?cvsroot=cluster&only_with_tag=STABLE&r1=1.1.6.1.2.1&r2=1.1.6.1.2.2
--- cluster/cman-kernel/src/Attic/sm_barrier.c 2005/06/22 04:41:52 1.1.6.1.2.1
+++ cluster/cman-kernel/src/Attic/sm_barrier.c 2006/09/25 15:23:01 1.1.6.1.2.2
@@ -141,6 +141,12 @@
{
sm_sevent_t *sev = sg->sevent;
+ if (!sev) {
+ log_error(sg, "process_startdone_barrier_new: no sev %d",
+ status);
+ return;
+ }
+
if (!test_and_clear_bit(SEFL_ALLOW_BARRIER, &sev->se_flags)) {
log_debug(sev->se_sg, "ignore barrier cb status %d", status);
return;
^ permalink raw reply [flat|nested] 2+ messages in thread* [Cluster-devel] cluster/cman-kernel/src sm_barrier.c
@ 2006-09-13 14:46 teigland
0 siblings, 0 replies; 2+ messages in thread
From: teigland @ 2006-09-13 14:46 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: teigland at sourceware.org 2006-09-13 14:46:52
Modified files:
cman-kernel/src: sm_barrier.c
Log message:
process_startdone_barrier_new() can be called when sg->sevent is
NULL, but we weren't checking for NULL and just deferencing the
sev->flags which led to oops in bz 206212.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman-kernel/src/sm_barrier.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.1&r2=1.1.2.2
--- cluster/cman-kernel/src/Attic/sm_barrier.c 2005/06/06 03:50:34 1.1.2.1
+++ cluster/cman-kernel/src/Attic/sm_barrier.c 2006/09/13 14:46:52 1.1.2.2
@@ -141,6 +141,12 @@
{
sm_sevent_t *sev = sg->sevent;
+ if (!sev) {
+ log_error(sg, "process_startdone_barrier_new: no sev %d",
+ status);
+ return;
+ }
+
if (!test_and_clear_bit(SEFL_ALLOW_BARRIER, &sev->se_flags)) {
log_debug(sev->se_sg, "ignore barrier cb status %d", status);
return;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-25 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-25 15:23 [Cluster-devel] cluster/cman-kernel/src sm_barrier.c teigland
-- strict thread matches above, loose matches on Subject: below --
2006-09-13 14:46 teigland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).