From: wcheng@sourceware.org <wcheng@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/gfs dir.c
Date: 26 Sep 2006 05:32:18 -0000 [thread overview]
Message-ID: <20060926053218.5329.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: wcheng at sourceware.org 2006-09-26 05:32:17
Modified files:
gfs-kernel/src/gfs: dir.c
Log message:
Bugzilla 205592:
One problem we've found is that under heavy system load, memory could
be in shortage that results in kmalloc() failure. In previous versions,
upon kmalloc() failure, in certain code paths, sometime it was impossible
to back out - so GFS either panic or hung. In newer versions of GFS, a fix
was added to allow memory allocation falling back to vmalloc() if kmalloc()
failed. Unfortuntely, the linux/vmalloc.h header was not added. Since the
compiler has not been not able to get the correct vmalloc() prototype, it
assumes the default that casts vmalloc() return code to "int" which is 4
byes. This could cause panic with 64 machines (e.g. x86_64) that uses 8
bytes addressing.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/dir.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.8.2.4&r2=1.8.2.5
--- cluster/gfs-kernel/src/gfs/dir.c 2006/02/19 23:37:23 1.8.2.4
+++ cluster/gfs-kernel/src/gfs/dir.c 2006/09/26 05:32:17 1.8.2.5
@@ -64,6 +64,7 @@
#include <asm/semaphore.h>
#include <linux/completion.h>
#include <linux/buffer_head.h>
+#include <linux/vmalloc.h>
#include "gfs.h"
#include "dio.h"
next reply other threads:[~2006-09-26 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 5:32 wcheng [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-26 14:30 [Cluster-devel] cluster/gfs-kernel/src/gfs dir.c wcheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060926053218.5329.qmail@sourceware.org \
--to=wcheng@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).