cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: rpeterso@sourceware.org <rpeterso@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/daemon main.c
Date: 20 Oct 2006 15:42:45 -0000	[thread overview]
Message-ID: <20061020154245.25131.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	rpeterso at sourceware.org	2006-10-20 15:42:44

Modified files:
	group/daemon   : main.c 

Log message:
	Fix for Bugzilla Bug 211405: If groupd segfaults, dump the most
	recent log information.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/daemon/main.c.diff?cvsroot=cluster&r1=1.48&r2=1.49

--- cluster/group/daemon/main.c	2006/10/06 16:55:19	1.48
+++ cluster/group/daemon/main.c	2006/10/20 15:42:44	1.49
@@ -10,10 +10,14 @@
 *******************************************************************************
 ******************************************************************************/
 
+#include <signal.h>
+#include <time.h>
+
 #include "gd_internal.h"
 
 #define OPTION_STRING			"DhVv"
 #define LOCKFILE_NAME			"/var/run/groupd.pid"
+#define LOG_FILE				"/var/log/groupd.log"
 
 extern struct list_head recovery_sets;
 
@@ -541,19 +545,19 @@
 	return 0;
 }
 
-static int do_dump(int ci, int argc, char **argv)
+static int do_dump(int fd)
 {
 	int rv, len;
 
 	if (dump_wrap) {
 		len = DUMP_SIZE - dump_point;
-		rv = write(client[ci].fd, dump_buf + dump_point, len);
+		rv = write(fd, dump_buf + dump_point, len);
 		if (rv != len)
 			log_print("write error %d errno %d", rv, errno);
 	}
 	len = dump_point;
 
-	rv = write(client[ci].fd, dump_buf, len);
+	rv = write(fd, dump_buf, len);
 	if (rv != len)
 		log_print("write error %d errno %d", rv, errno);
 	return 0;
@@ -650,7 +654,7 @@
 		break;
 
 	case DO_DUMP:
-		do_dump(ci, argc, argv);
+		do_dump(client[ci].fd);
 		break;
 
 	default:
@@ -903,6 +907,30 @@
 	}
 }
 
+void bail_with_log(int sig)
+{
+	int fd;
+	time_t now;
+
+	unlink(LOG_FILE);
+	fd = creat(LOG_FILE, S_IRUSR | S_IWUSR);
+	if (fd > 0) {
+		char now_ascii[32];
+
+		do_dump(fd);
+		memset(now_ascii, 0, sizeof(now_ascii));
+		time(&now);
+		sprintf(now_ascii, "%ld", now);
+		write(fd, now_ascii, strlen(now_ascii));
+		write(fd, " groupd segfault log follows:\n", 30);
+		close(fd);
+	}
+	else
+		perror(LOG_FILE);
+	if (sig == SIGSEGV)
+		exit(0);
+}
+
 int main(int argc, char *argv[])
 {
 	prog_name = argv[0];
@@ -915,6 +943,8 @@
 
 	decode_arguments(argc, argv);
 
+	signal(SIGSEGV, bail_with_log);
+	signal(SIGUSR1, bail_with_log);
 	if (!groupd_debug_opt)
 		daemonize();
 



             reply	other threads:[~2006-10-20 15:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-20 15:42 rpeterso [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-01-11 17:59 [Cluster-devel] cluster/group/daemon main.c teigland
2007-01-11 17:59 teigland
2006-12-13 19:05 teigland
2006-12-13 19:05 teigland
2006-12-13 19:04 teigland
2006-12-01 15:25 teigland
2006-12-01 15:25 teigland
2006-12-01 15:24 teigland
2006-11-20 22:44 rpeterso
2006-11-17 16:28 teigland
2006-11-17 16:26 teigland
2006-11-15 14:35 teigland
2006-10-24 17:08 teigland
2006-09-14 20:49 teigland
2006-07-13 18:21 teigland
2006-06-22 19:06 teigland
2006-06-20 20:27 teigland
2006-06-14 21:38 teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061020154245.25131.qmail@sourceware.org \
    --to=rpeterso@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).