cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c
Date: 24 Oct 2006 21:04:32 -0000	[thread overview]
Message-ID: <20061024210432.16776.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	jbrassow at sourceware.org	2006-10-24 21:04:31

Modified files:
	cmirror-kernel/src: dm-cmirror-client.c 

Log message:
	- Bug 194131 - cluster mirror copy status can give false (0.00) percent
	
	An error during communication can lead to a false reporting of 0%
	in-sync regions.  This can't be completely eliminated until rhel5,
	but we can at least retry a couple times in rhel4.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-client.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.25&r2=1.1.2.26

--- cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/09/08 15:53:56	1.1.2.25
+++ cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/10/24 21:04:31	1.1.2.26
@@ -1040,6 +1040,7 @@
 
 static region_t cluster_get_sync_count(struct dirty_log *log)
 {
+	int i;
 	region_t rtn;
 	struct log_c *lc = (struct log_c *) log->context;
 /* take out optimization
@@ -1047,7 +1048,9 @@
 		return lc->region_count;
 	}
 */
-	if(consult_server(lc, 0, LRT_GET_SYNC_COUNT, &rtn)){
+	/* Try to get sync count up to five times */
+	for (i = 0; i < 5 && consult_server(lc, 0, LRT_GET_SYNC_COUNT, &rtn); i++);
+	if(i >= 5){
 		return 0;
 	}
 



             reply	other threads:[~2006-10-24 21:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-24 21:04 jbrassow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-08-23 16:51 [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c jbrassow
2007-05-09 21:44 jbrassow
2007-03-02 22:31 jbrassow
2006-12-05 17:49 jbrassow
2006-12-05 15:08 jbrassow
2006-12-05  3:13 jbrassow
2006-11-27 23:15 jbrassow
2006-11-27 22:36 jbrassow
2006-11-07 20:48 jbrassow
2006-09-08 15:54 jbrassow
2006-09-08 15:52 jbrassow
2006-07-07 17:12 jbrassow
2006-07-07 17:09 jbrassow
2006-07-07 17:08 jbrassow
2006-06-15 17:53 jbrassow
2006-06-15 17:44 jbrassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061024210432.16776.qmail@sourceware.org \
    --to=jbrassow@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).