cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/luci/site/luci/Extensions ricci_bridge.py
Date: 31 Oct 2006 13:51:54 -0000	[thread overview]
Message-ID: <20061031135154.14237.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	conga
Changes by:	rmccabe at sourceware.org	2006-10-31 13:51:54

Modified files:
	luci/site/luci/Extensions: ricci_bridge.py 

Log message:
	fix non-async callers of batch_run to expect the first node to be '<?xml ...'

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/site/luci/Extensions/ricci_bridge.py.diff?cvsroot=cluster&r1=1.38&r2=1.39

--- conga/luci/site/luci/Extensions/ricci_bridge.py	2006/10/31 13:16:30	1.38
+++ conga/luci/site/luci/Extensions/ricci_bridge.py	2006/10/31 13:51:53	1.39
@@ -279,7 +279,10 @@
 	batch_str ='<module name="cluster"><request API_version="1.0"><function_call name="status"/></request></module>'
 	ricci_xml = rc.batch_run(batch_str, async=False)
 
-	doc = getPayload(ricci_xml)
+	if not ricci_xml or not ricci_xml.firstChild:
+		luci_log.debug_verbose('ricci_xml is None from batch_run')
+		
+	doc = getPayload(ricci_xml.firstChild)
 	if not doc or not doc.firstChild:
 		luci_log.debug_verbose('doc is None from getPayload: %s' % ricci_xml.toxml())
 		return None
@@ -419,9 +422,10 @@
 	batch_str += '</var></function_call></request></module>'
 
 	ricci_xml = rc.batch_run(batch_str, async=False)
-	if not ricci_xml:
+	if not ricci_xml or not ricci_xml.firstChild:
+		luci_log.debug_verbose('no ricci_xml in getDaemonStates')
 		return None
-	result = extractDaemonInfo(ricci_xml)
+	result = extractDaemonInfo(ricci_xml.firstChild)
 	return result
 
 def extractDaemonInfo(bt_node):



             reply	other threads:[~2006-10-31 13:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-31 13:51 rmccabe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-03-21 17:18 [Cluster-devel] conga/luci/site/luci/Extensions ricci_bridge.py rmccabe
2007-03-21 17:16 rmccabe
2007-03-21 17:14 rmccabe
2007-03-01  0:40 rmccabe
2006-12-12 19:03 rmccabe
2006-12-10 19:19 rmccabe
2006-11-20 23:36 rmccabe
2006-11-20 23:30 rmccabe
2006-11-20 23:30 rmccabe
2006-11-16 20:22 rmccabe
2006-11-16 20:20 rmccabe
2006-10-25 16:01 rmccabe
2006-10-25 16:00 rmccabe
2006-10-23 19:31 jparsons
2006-10-23 19:24 jparsons
2006-10-16 20:56 rmccabe
2006-10-16 14:56 rmccabe
2006-10-12 22:41 rmccabe
2006-10-12 21:57 rmccabe
2006-10-09 20:17 rmccabe
2006-08-14 16:01 jparsons
2006-08-12 17:59 jparsons
2006-07-31 22:16 jparsons
2006-07-31 21:18 kupcevic
2006-07-31 18:55 jparsons
2006-07-28 19:46 jparsons
2006-07-27 14:24 jparsons
2006-07-19 22:50 rmccabe
2006-07-19 21:02 rmccabe
2006-07-17 21:58 jparsons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061031135154.14237.qmail@sourceware.org \
    --to=rmccabe@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).