cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: pcaulfield@sourceware.org <pcaulfield@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cman/daemon ais.c
Date: 31 Oct 2006 17:27:46 -0000	[thread overview]
Message-ID: <20061031172746.10810.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	pcaulfield at sourceware.org	2006-10-31 17:27:45

Modified files:
	cman/daemon    : ais.c 

Log message:
	On Steven Dake's recommendation, also up the token_retransmit count to 20.
	and fix a couple of typos.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/daemon/ais.c.diff?cvsroot=cluster&r1=1.43&r2=1.44

--- cluster/cman/daemon/ais.c	2006/10/31 09:28:12	1.43
+++ cluster/cman/daemon/ais.c	2006/10/31 17:27:45	1.44
@@ -470,7 +470,7 @@
 			       "totem", strlen("totem"),
 			       &object_handle) == 0)
 	{
-		void *value = NULL;
+		char *value;
 
 		objdb->object_key_create(object_handle, "version", strlen("version"),
 					 "2", 2);
@@ -482,12 +482,17 @@
 		objdb->object_key_create(object_handle, "vsftype", strlen("vsftype"),
 					 "none", strlen("none")+1);
 
-		/* Set the token timeout is 5 seconds, but don't overrride anything that
+		/* Set the token timeout is 5 seconds - 20 losses, but don't overrride anything that
 		   might be in cluster.conf */
-		if (objdb->object_key_get(object_handle, "token", strlen("token"), &value, NULL) || value == NULL) {
+		if (objdb_get_string(objdb, object_handle, "token", &value)) {
 			global_objdb->object_key_create(object_handle, "token", strlen("token"),
 							"5000", strlen("5000")+1);
 		}
+		if (objdb_get_string(objdb, object_handle, "token_retransmits_before_loss_const", &value)) {
+			global_objdb->object_key_create(object_handle, "token_retransmits_before_loss_const",
+							strlen("token_retransmits_before_loss_const"),
+							"20", strlen("20")+1);
+		}
 
 		/* Set RRP mode appropriately */
 		if (num_interfaces > 1) {
@@ -509,7 +514,7 @@
 						 key_filename, strlen(key_filename)+1);
 		}
 		else /* Use the cluster name as key,
-		      * This isn't a good isolation strategey but it does make sure that
+		      * This isn't a good isolation strategy but it does make sure that
 		      * clusters on the same port/multicast by mistake don't actually interfere
 		      * and that we have some form of encryption going.
 		      */
@@ -536,7 +541,7 @@
 		char *logstr;
 
 		/* Default logging facility is "local4" unless overridden by the user */
-		if (!objdb_get_string(objdb, object_handle, "syslog_facility", &logstr)) {
+		if (objdb_get_string(objdb, object_handle, "syslog_facility", &logstr)) {
 			objdb->object_key_create(object_handle, "syslog_facility", strlen("syslog_facility"),
 						 "local4", strlen("local4")+1);
 		}



             reply	other threads:[~2006-10-31 17:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-31 17:27 pcaulfield [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-02 11:05 [Cluster-devel] cluster/cman/daemon ais.c pcaulfield
2007-12-31  5:15 fabbione
2007-12-30  9:30 fabbione
2007-12-13 13:39 pcaulfield
2007-11-01 14:06 pcaulfield
2007-10-15 14:48 pcaulfield
2007-10-01 12:36 pcaulfield
2007-05-10  9:05 pcaulfield
2007-05-09 16:16 pcaulfield
2007-05-03 12:18 pcaulfield
2007-05-04  2:30 ` Steven Dake
2007-05-04  0:07   ` Steven Dake
2006-12-18  9:49 pcaulfield
2006-12-18  9:48 pcaulfield
2006-12-18  9:37 pcaulfield
2006-11-09 13:51 pcaulfield
2006-11-09 13:50 pcaulfield
2006-11-09 13:10 pcaulfield
2006-10-31  9:28 pcaulfield
2006-09-25 11:38 pcaulfield
2006-08-11  7:09 pcaulfield
2006-08-10 19:45 rpeterso
2006-08-09  9:46 pcaulfield
2006-07-19  8:33 pcaulfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061031172746.10810.qmail@sourceware.org \
    --to=pcaulfield@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).