cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: rohara@sourceware.org <rohara@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs2/fsck metawalk.c
Date: 20 Nov 2006 15:44:53 -0000	[thread overview]
Message-ID: <20061120154453.3899.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL5
Changes by:	rohara at sourceware.org	2006-11-20 15:44:53

Modified files:
	gfs2/fsck      : metawalk.c 

Log message:
	Fix another case where lf_dirent_format was not rewritten to disk
	after it was fixed.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/fsck/metawalk.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.3.2.2&r2=1.3.2.3

--- cluster/gfs2/fsck/metawalk.c	2006/11/16 19:56:09	1.3.2.2
+++ cluster/gfs2/fsck/metawalk.c	2006/11/20 15:44:53	1.3.2.3
@@ -162,8 +162,7 @@
 				}
 			}
 
-			enum update_flags u = not_updated;
-
+			*update = not_updated;
 			lbh = bread(sbp, leaf_no);
 			gfs2_leaf_in(&leaf, lbh->b_data);
 
@@ -177,7 +176,8 @@
 				log_debug("incorrect lf_dirent_format at leaf #%" PRIu64 "\n", leaf_no);
 				leaf.lf_dirent_format = GFS2_FORMAT_DE;
 				gfs2_leaf_out(&leaf, lbh->b_data);
-				u = updated;
+				log_debug("Fixing lf_dirent_format.\n");
+				*update = updated;
 			}
 
 			exp_count = (1 << (ip->i_di.di_depth - leaf.lf_depth));
@@ -227,9 +227,7 @@
 				 * compare it against leaf->lf_entries */
 				break;
 			} else {
-				if (u == updated)
-					log_debug("Fixing lf_dirent_format.\n");
-				brelse(lbh, u);
+				brelse(lbh, *updated);
 				if(!leaf.lf_next)
 					break;
 				leaf_no = leaf.lf_next;



             reply	other threads:[~2006-11-20 15:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20 15:44 rohara [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-02-26 19:20 [Cluster-devel] cluster/gfs2/fsck metawalk.c rpeterso
2007-02-26 19:19 rpeterso
2007-01-23 19:54 rpeterso
2007-01-23 19:44 rpeterso
2006-11-20 21:46 rpeterso
2006-11-20 21:30 rpeterso
2006-11-20 15:35 rpeterso
2006-11-16 20:12 rohara
2006-11-16 19:56 rohara
2006-11-14 22:55 rpeterso
2006-11-14 22:51 rpeterso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061120154453.3899.qmail@sourceware.org \
    --to=rohara@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).