cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c
Date: 27 Nov 2006 22:36:49 -0000	[thread overview]
Message-ID: <20061127223649.24377.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	jbrassow at sourceware.org	2006-11-27 22:36:48

Modified files:
	cmirror-kernel/src: dm-cmirror-client.c 

Log message:
	Bug 214517: hung cmirror operations due to looping mirror region requests
	
	Once we've completed handling a new server, we must reset the 'new_server'
	variable, so that if we need to retry a request we don't go through the
	whole process again.
	
	Also, added more error reporting for when a request must be retried.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-client.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.27&r2=1.1.2.28

--- cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/11/07 20:48:16	1.1.2.27
+++ cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/11/27 22:36:48	1.1.2.28
@@ -406,6 +406,7 @@
 
 	if(len <= 0){
 		/* ATTENTION -- what do we do with this ? */
+		DMWARN("Error while listening for server response: %d", len);
 		error = len;
 		*retry = 1;
 		goto fail;
@@ -420,6 +421,8 @@
 	}
 
 	if (lr->u.lr_int_rtn == -ENXIO) {
+		DMDEBUG("Server (%u) says it no longer controls this log (%s)",
+			lc->server_id, lc->uuid + (strlen(lc->uuid) - 8));
 		lc->server_id = 0xDEAD;
 		*retry = 1;
 		goto fail;
@@ -540,6 +543,7 @@
 				      (type == LRT_SELECTION)? "LRT_SELECTION": "UNKNOWN"
 					);
 			}
+			new_server = 0;
 		}
 
 		rs = NULL;



             reply	other threads:[~2006-11-27 22:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27 22:36 jbrassow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-08-23 16:51 [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c jbrassow
2007-05-09 21:44 jbrassow
2007-03-02 22:31 jbrassow
2006-12-05 17:49 jbrassow
2006-12-05 15:08 jbrassow
2006-12-05  3:13 jbrassow
2006-11-27 23:15 jbrassow
2006-11-07 20:48 jbrassow
2006-10-24 21:04 jbrassow
2006-09-08 15:54 jbrassow
2006-09-08 15:52 jbrassow
2006-07-07 17:12 jbrassow
2006-07-07 17:09 jbrassow
2006-07-07 17:08 jbrassow
2006-06-15 17:53 jbrassow
2006-06-15 17:44 jbrassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061127223649.24377.qmail@sourceware.org \
    --to=jbrassow@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).