From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c
Date: 27 Nov 2006 23:15:48 -0000 [thread overview]
Message-ID: <20061127231548.15970.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: jbrassow at sourceware.org 2006-11-27 23:15:45
Modified files:
cmirror-kernel/src: dm-cmirror-client.c
Log message:
Bug 217438: scrolling kernel requests to mark mirror regions
It is sometimes possible for a mark request to be issued on a region
that is being recovered. The mark must be delayed until the recovery
is complete. This is what was happening, but a rather severe error
was being reported and the (mark region) retries were happening too
fast.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-client.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.28&r2=1.1.2.29
--- cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c 2006/11/27 22:36:48 1.1.2.28
+++ cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c 2006/11/27 23:15:43 1.1.2.29
@@ -941,9 +941,19 @@
spin_unlock(®ion_state_lock);
while((error = consult_server(lc, region, LRT_MARK_REGION, NULL))){
+ if (error == -EBUSY) {
+ /* Remote recovering delay and try again */
+ DMDEBUG("Delaying mark to region %Lu, due to recovery",
+ region);
+ set_current_state(TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ/2);
+ continue;
+ }
+
DMWARN("unable to get server (%u) to mark region (%Lu)",
lc->server_id, region);
DMWARN("Reason :: %d", error);
+
if (error == -EIO) {
lc->log_dev_failed = 1;
break;
next reply other threads:[~2006-11-27 23:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 23:15 jbrassow [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-23 16:51 [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c jbrassow
2007-05-09 21:44 jbrassow
2007-03-02 22:31 jbrassow
2006-12-05 17:49 jbrassow
2006-12-05 15:08 jbrassow
2006-12-05 3:13 jbrassow
2006-11-27 22:36 jbrassow
2006-11-07 20:48 jbrassow
2006-10-24 21:04 jbrassow
2006-09-08 15:54 jbrassow
2006-09-08 15:52 jbrassow
2006-07-07 17:12 jbrassow
2006-07-07 17:09 jbrassow
2006-07-07 17:08 jbrassow
2006-06-15 17:53 jbrassow
2006-06-15 17:44 jbrassow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127231548.15970.qmail@sourceware.org \
--to=jbrassow@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).