cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c
Date: 5 Dec 2006 03:13:52 -0000	[thread overview]
Message-ID: <20061205031352.4120.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	jbrassow at sourceware.org	2006-12-05 03:13:51

Modified files:
	cmirror-kernel/src: dm-cmirror-client.c 

Log message:
	Bug 214487: "Attempt to mark a already marked region" messages when ...
	
	When a log server moves (like durring a failure or the mirror being
	shutdown on that node), the clients send the new server the regions
	that they have marked.
	
	However, the clients where sending _all_ of the regions they had
	marked for every mirror that was active - even for the ones whose
	log server had not moved.  This was causing those servers to report
	that they already had those regions marked.
	
	Other than the annoying messages, I don't believe there were any
	side affects of this bug.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-client.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.29&r2=1.1.2.30

--- cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/11/27 23:15:43	1.1.2.29
+++ cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/12/05 03:13:50	1.1.2.30
@@ -512,6 +512,9 @@
 
 			DMINFO(" - Resending all mark region requests");
 			list_for_each_entry(rs, &marked_region_list, rs_list){
+				/* Resend only those associated with referenced log */
+				if (rs->rs_lc != lc)
+					continue;
 				do {
 					retry = 0;
 					DMINFO("   - " SECTOR_FORMAT, rs->rs_region);



             reply	other threads:[~2006-12-05  3:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-05  3:13 jbrassow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-08-23 16:51 [Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c jbrassow
2007-05-09 21:44 jbrassow
2007-03-02 22:31 jbrassow
2006-12-05 17:49 jbrassow
2006-12-05 15:08 jbrassow
2006-11-27 23:15 jbrassow
2006-11-27 22:36 jbrassow
2006-11-07 20:48 jbrassow
2006-10-24 21:04 jbrassow
2006-09-08 15:54 jbrassow
2006-09-08 15:52 jbrassow
2006-07-07 17:12 jbrassow
2006-07-07 17:09 jbrassow
2006-07-07 17:08 jbrassow
2006-06-15 17:53 jbrassow
2006-06-15 17:44 jbrassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061205031352.4120.qmail@sourceware.org \
    --to=jbrassow@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).