From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Fri, 12 Aug 2011 09:55:39 -0400 (EDT) Subject: [Cluster-devel] [Patch 04/44] libgfs2: Make check_sb and read_sb operate on gfs1 file systems In-Reply-To: <1313139819.2704.17.camel@menhir> Message-ID: <2006229190.552336.1313157339372.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | Hi, | | The return values are a bit confusing, could we have 1 for gfs1, 2 for | gfs2, and negative for error? Also lets call these functions | libgfs2_check_sb etc, to try and keep the interface clean, | | Steve. Hi, Good idea. Since the change was pretty pervasive, I broke it into two patches: 03/44 and 04/44. The idea behind patch 3 was to add the gfs1 variable to the in-core superblock structure without changing the logic to minimize wading through ugly logic. The idea behind patch 4 was to set the variable when the superblock is read in, and fix up the logic accordingly, but I should be done it more cleanly. I'll redesign patch 4 and send out a replacement. Regards, Bob Peterson Red Hat File Systems