cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: pcaulfield@sourceware.org <pcaulfield@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cman/daemon commands.c
Date: 17 Jan 2007 11:01:36 -0000	[thread overview]
Message-ID: <20070117110136.25034.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL5
Changes by:	pcaulfield at sourceware.org	2007-01-17 11:01:35

Modified files:
	cman/daemon    : commands.c 

Log message:
	If we get killed by another node then print the reason in English rather
	than just a number.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cman/daemon/commands.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.55.2.4&r2=1.55.2.5

--- cluster/cman/daemon/commands.c	2007/01/16 09:57:20	1.55.2.4
+++ cluster/cman/daemon/commands.c	2007/01/17 11:01:35	1.55.2.5
@@ -2,7 +2,7 @@
 *******************************************************************************
 **
 **  Copyright (C) Sistina Software, Inc.  1997-2003  All rights reserved.
-**  Copyright (C) 2004-2006 Red Hat, Inc.  All rights reserved.
+**  Copyright (C) 2004-2007 Red Hat, Inc.  All rights reserved.
 **
 **  This copyrighted material is made available to anyone wishing to use,
 **  modify, copy, or redistribute it subject to the terms and conditions
@@ -97,6 +97,7 @@
 static void process_internal_message(char *data, int len, int nodeid, int byteswap);
 static void recalculate_quorum(int allow_decrease);
 static void send_kill(int nodeid, uint16_t reason);
+static char *killmsg_reason(int reason);
 
 static void set_port_bit(struct cluster_node *node, uint8_t port)
 {
@@ -1817,7 +1818,8 @@
 		killmsg = (struct cl_killmsg *)data;
 		P_MEMB("got KILL for node %d\n", killmsg->nodeid);
 		if (killmsg->nodeid == wanted_nodeid) {
-			log_msg(LOG_INFO, "cman killed by node %d for reason %d\n", nodeid, killmsg->reason);
+			log_msg(LOG_INFO, "cman killed by node %d because %s\n", nodeid,
+				killmsg_reason(killmsg->reason));
 			exit(1);
 		}
 		break;
@@ -2040,3 +2042,23 @@
 	return NULL;
 }
 
+static char *killmsg_reason(int reason)
+{
+	static char msg[1024];
+
+	switch (reason)
+	{
+	case CLUSTER_KILL_REJECTED:
+		return "our membership application was rejected";
+
+	case CLUSTER_KILL_CMANTOOL:
+		return "we were killed by cman_tool or other application";
+
+	case CLUSTER_KILL_REJOIN:
+		return "we node rejoined cluster without a full restart";
+
+	default:
+		sprintf(msg, "we got kill message number %d", reason);
+		return msg;
+	}
+}



             reply	other threads:[~2007-01-17 11:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-17 11:01 pcaulfield [this message]
2007-01-17 14:50 ` [Cluster-devel] cluster/cman/daemon commands.c Robert Peterson
  -- strict thread matches above, loose matches on Subject: below --
2008-02-04 10:54 pcaulfield
2008-01-03 16:36 pcaulfield
2008-01-03 16:35 pcaulfield
2008-01-03 20:40 ` Fabio M. Di Nitto
2008-01-03  6:48 fabbione
2008-01-02 16:23 pcaulfield
2008-01-02 10:02 pcaulfield
2008-01-02  9:27 pcaulfield
2007-11-26 17:03 lhh
2007-11-20  9:21 pcaulfield
2007-11-20  9:02 pcaulfield
2007-09-27  9:05 pcaulfield
2007-09-27  9:01 pcaulfield
2007-09-17 13:35 pcaulfield
2007-09-07 12:17 pcaulfield
2007-08-22  7:05 pcaulfield
2007-01-17 15:02 pcaulfield
2007-01-17 15:02 pcaulfield
2007-01-17 11:00 pcaulfield
2007-01-16 16:31 pcaulfield
2007-01-16  9:57 pcaulfield
2007-01-16  9:54 pcaulfield
2007-01-09 13:32 pcaulfield
2007-01-09 13:31 pcaulfield
2007-01-08 10:16 pcaulfield
2007-01-08 10:16 pcaulfield
2006-12-13 14:20 pcaulfield
2006-12-13 13:39 pcaulfield
2006-12-13 13:38 pcaulfield
2006-11-06 10:06 pcaulfield
2006-10-16 14:10 pcaulfield
2006-10-10 15:14 pcaulfield
2006-09-12 12:45 pcaulfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070117110136.25034.qmail@sourceware.org \
    --to=pcaulfield@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).