From: rpeterso@sourceware.org <rpeterso@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs2/fsck metawalk.c
Date: 23 Jan 2007 19:44:13 -0000 [thread overview]
Message-ID: <20070123194413.2552.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: rpeterso at sourceware.org 2007-01-23 19:44:12
Modified files:
gfs2/fsck : metawalk.c
Log message:
Resolves: bz 223843 GFS2: gfs2_fsck segfaulting on corrupt extended
attributes
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/fsck/metawalk.c.diff?cvsroot=cluster&r1=1.6&r2=1.7
--- cluster/gfs2/fsck/metawalk.c 2006/11/20 15:35:12 1.6
+++ cluster/gfs2/fsck/metawalk.c 2007/01/23 19:44:12 1.7
@@ -247,6 +247,7 @@
uint64_t *ea_data_ptr = NULL;
int i;
int error = 0;
+ uint32_t offset = (uint32_t)sizeof(struct gfs2_meta_header);
if(!pass->check_eattr_entry) {
return 0;
@@ -287,11 +288,11 @@
}
}
}
- if(ea_hdr->ea_flags & GFS2_EAFLAG_LAST){
- /* FIXME: better equal the end of the block */
+ offset += be32_to_cpu(ea_hdr->ea_rec_len);
+ if(ea_hdr->ea_flags & GFS2_EAFLAG_LAST ||
+ offset >= ip->i_sbd->sd_sb.sb_bsize || ea_hdr->ea_rec_len == 0){
break;
}
- /* FIXME: be sure this doesn't go beyond the end */
ea_hdr_prev = ea_hdr;
ea_hdr = (struct gfs2_ea_header *)
((char *)(ea_hdr) +
next reply other threads:[~2007-01-23 19:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 19:44 rpeterso [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-26 19:20 [Cluster-devel] cluster/gfs2/fsck metawalk.c rpeterso
2007-02-26 19:19 rpeterso
2007-01-23 19:54 rpeterso
2006-11-20 21:46 rpeterso
2006-11-20 21:30 rpeterso
2006-11-20 15:44 rohara
2006-11-20 15:35 rpeterso
2006-11-16 20:12 rohara
2006-11-16 19:56 rohara
2006-11-14 22:55 rpeterso
2006-11-14 22:51 rpeterso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070123194413.2552.qmail@sourceware.org \
--to=rpeterso@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).