cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/luci/cluster validate_fence.js
Date: 16 Feb 2007 23:25:27 -0000	[thread overview]
Message-ID: <20070216232527.25290.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	conga
Changes by:	rmccabe at sourceware.org	2007-02-16 23:25:27

Modified files:
	luci/cluster   : validate_fence.js 

Log message:
	Fix a front-end fence instance validation bug.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&r1=1.5&r2=1.6

--- conga/luci/cluster/validate_fence.js	2007/02/12 23:26:54	1.5
+++ conga/luci/cluster/validate_fence.js	2007/02/16 23:25:27	1.6
@@ -146,9 +146,11 @@
 
 	for (var i = 0 ; i < fields.length ; i++) {
 		var field_name = fields[i];
-		var err = field_validator[field_name](form, form[field_name]);
-		if (err)
-			errors = errors.concat(err);
+		if (form[field_name]) {
+			var err = field_validator[field_name](form, form[field_name]);
+			if (err)
+				errors = errors.concat(err);
+		}
 	}
 
 	return (errors);
@@ -183,9 +185,11 @@
 
 	for (var i = 0 ; i < fields.length ; i++) {
 		var field_name = fields[i];
-		var err = field_validator[field_name](form[field_name]);
-		if (err)
-			errors = errors.concat(err);
+		if (form[field_name]) {
+			var err = field_validator[field_name](form, form[field_name]);
+			if (err)
+				errors = errors.concat(err);
+		}
 	}
 
 	return (errors);



             reply	other threads:[~2007-02-16 23:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 23:25 rmccabe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-23 17:23 [Cluster-devel] conga/luci/cluster validate_fence.js rmccabe
2007-07-26  4:14 rmccabe
2007-07-23 15:09 rmccabe
2007-02-16 23:26 rmccabe
2006-10-04 17:25 kupcevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070216232527.25290.qmail@sourceware.org \
    --to=rmccabe@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).