From: Andrew Morton <akpm@linux-foundation.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 patch] fix locking mistake
Date: Wed, 21 Feb 2007 14:37:12 -0800 [thread overview]
Message-ID: <20070221143712.f0ed79bd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070220050328.GB1836@korben.rdu.redhat.com>
On Tue, 20 Feb 2007 00:03:29 -0500
Josef Whiter <jwhiter@redhat.com> wrote:
> This patch fixes a locking mistake in the quota code, we do a mutex_lock instead
> of a mutex_unlock.
>
> Signed-off-by: Josef Whiter <jwhiter@redhat.com>
>
> --- linux-2.6/fs/gfs2/quota.c.josef 2007-02-20 00:41:23.000000000 -0500
> +++ linux-2.6/fs/gfs2/quota.c 2007-02-20 00:51:58.000000000 -0500
> @@ -279,7 +279,7 @@ static int bh_get(struct gfs2_quota_data
> (bh->b_data + sizeof(struct gfs2_meta_header) +
> offset * sizeof(struct gfs2_quota_change));
>
> - mutex_lock(&sdp->sd_quota_mutex);
> + mutex_unlock(&sdp->sd_quota_mutex);
>
> return 0;
>
whaaa? There's no way that any of that code has ever been executed, surely??
Oh well, I'll tag this for consideration by the -stable team.
next prev parent reply other threads:[~2007-02-21 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 5:03 [Cluster-devel] [GFS2 patch] fix locking mistake Josef Whiter
2007-02-21 22:37 ` Andrew Morton [this message]
2007-02-21 22:39 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221143712.f0ed79bd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).