From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 21 Feb 2007 14:37:12 -0800
Subject: [Cluster-devel] [GFS2 patch] fix locking mistake
In-Reply-To: <20070220050328.GB1836@korben.rdu.redhat.com>
References: <20070220050328.GB1836@korben.rdu.redhat.com>
Message-ID: <20070221143712.f0ed79bd.akpm@linux-foundation.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Tue, 20 Feb 2007 00:03:29 -0500
Josef Whiter <jwhiter@redhat.com> wrote:

> This patch fixes a locking mistake in the quota code, we do a mutex_lock instead
> of a mutex_unlock.
> 
> Signed-off-by: Josef Whiter <jwhiter@redhat.com>
> 
> --- linux-2.6/fs/gfs2/quota.c.josef	2007-02-20 00:41:23.000000000 -0500
> +++ linux-2.6/fs/gfs2/quota.c	2007-02-20 00:51:58.000000000 -0500
> @@ -279,7 +279,7 @@ static int bh_get(struct gfs2_quota_data
>  		(bh->b_data + sizeof(struct gfs2_meta_header) +
>  		 offset * sizeof(struct gfs2_quota_change));
>  
> -	mutex_lock(&sdp->sd_quota_mutex);
> +	mutex_unlock(&sdp->sd_quota_mutex);
>  
>  	return 0;
>  

whaaa?  There's no way that any of that code has ever been executed, surely??

Oh well, I'll tag this for consideration by the -stable team.