From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Mon, 9 Apr 2007 19:49:02 +0100 Subject: [Cluster-devel] Re: [NFS] [PATCH 1/4 Revised] NLM - drop per fsid locks In-Reply-To: <46156F60.1040400@redhat.com> References: <46156F60.1040400@redhat.com> Message-ID: <20070409184902.GA30444@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Apr 05, 2007 at 05:51:28PM -0400, Wendy Cheng wrote: > By writing exported filesytem id into /proc/fs/nfsd/nlm_unlock, this > patch walks thru lockd's global nlm_files list to release all the locks > associated with the particular id. It is used to enable NFS lock > failover with active-active clustered servers. > > Relevant steps: > 1) Exports filesystem with "fsid" option as: > /etc/exports entry> /mnt/shared/exports *(fsid=1234,sync,rw) > 2) Drops locks based on fsid by: > shell> echo 1234 > /proc/fs/nfsd/nlm_unlock This is a very awkward API. Dropping locks should support uuid or dev_t based exports aswell. Also it would be nice if you we had a more general push api for changes to filesystem state, that works on a similar basis as getting information from /etc/exports. And please inline your patches into the mail I send, attaching them makes it really hard to quote it in mail replies or even to simply read it.