From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Kirch Date: Tue, 10 Apr 2007 08:57:46 -0000 Subject: [Cluster-devel] Re: [NFS] [PATCH 2/4 Revised] NLM - set per fsid grace period In-Reply-To: <46156F81.8010808@redhat.com> References: <46156F81.8010808@redhat.com> Message-ID: <200704101057.24105.okir@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thursday 05 April 2007 23:52, Wendy Cheng wrote: > This change enables per NFS-export entry lockd grace period. The > implementation is based on a double linked list fo_fsid_list that > contains entries of fsid info. It is expected this would not be a > frequent event. The fo_fsid_list is short and the entries expire within > a maximum of 50 seconds. The grace period setting follows the existing > NLM grace period handling logic and is triggered via echoing the NFS > export filesystem id into nfsd procfs entry as: Your patch creates a new per-export structure that is private to lockd. It may be easier to put the grace period value into the export entry, and check for that in nlm_fopen. It feels more natural than adding a whole new shadow export table just for the benefit of lockd. (Especially when you consider future extensions like being able to search the list by dev_t or uuid or whatever) Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play okir at lst.de | / | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax