cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs2/mount mount.gfs2.c util.h
Date: 26 Apr 2007 18:45:38 -0000	[thread overview]
Message-ID: <20070426184538.14371.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	teigland at sourceware.org	2007-04-26 19:45:37

Modified files:
	gfs2/mount     : mount.gfs2.c util.h 

Log message:
	Check right away if the kernel has gfs/gfs2 support by looking in
	/sys/fs/.  This results in a user-friendly error message instead of
	something like "gfs_controld error 19".

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/mount/mount.gfs2.c.diff?cvsroot=cluster&r1=1.21&r2=1.22
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs2/mount/util.h.diff?cvsroot=cluster&r1=1.10&r2=1.11

--- cluster/gfs2/mount/mount.gfs2.c	2007/04/23 19:18:09	1.21
+++ cluster/gfs2/mount/mount.gfs2.c	2007/04/26 18:45:37	1.22
@@ -150,6 +150,25 @@
 		lock_dlm_leave(mo, sb, mnterr);
 }
 
+static void check_sys_fs(char *fsname)
+{
+	DIR *d;
+	struct dirent *de;
+
+	d = opendir("/sys/fs/");
+	if (!d)
+		die("no /sys/fs/ directory found: %d\n", errno);
+
+	while ((de = readdir(d))) {
+		if (strnlen(fsname, 5) != strnlen(de->d_name, 5))
+			continue;
+		if (!strncmp(fsname, de->d_name, strnlen(fsname, 5)))
+			return;
+	}
+	die("fs type \"%s\" not found in /sys/fs/, is the module loaded?\n",
+	    fsname);
+}
+
 int main(int argc, char **argv)
 {
 	struct mount_options mo;
@@ -172,6 +191,8 @@
 		exit(EXIT_SUCCESS);
 	}
 
+	check_sys_fs(fsname);
+
 	read_options(argc, argv, &mo);
 	check_options(&mo);
 	get_sb(mo.dev, &sb);
--- cluster/gfs2/mount/util.h	2006/10/13 20:01:19	1.10
+++ cluster/gfs2/mount/util.h	2007/04/26 18:45:37	1.11
@@ -20,6 +20,7 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <limits.h>
+#include <dirent.h>
 #include <errno.h>
 #include <signal.h>
 #include <sys/socket.h>



             reply	other threads:[~2007-04-26 18:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26 18:45 teigland [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-04-26 18:45 [Cluster-devel] cluster/gfs2/mount mount.gfs2.c util.h teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070426184538.14371.qmail@sourceware.org \
    --to=teigland@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).