From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] GFS2: kernel changes to support new gfs2_grow command (Try 3)
Date: Fri, 4 May 2007 15:23:17 -0500 [thread overview]
Message-ID: <20070504202317.GA16877@redhat.com> (raw)
In-Reply-To: <46394174.2030709@redhat.com>
On Wed, May 02, 2007 at 08:57:08PM -0500, Robert Peterson wrote:
> @@ -978,18 +1038,25 @@ int gfs2_inplace_reserve_i(struct gfs2_inode *ip,
> - error = gfs2_rindex_hold(sdp, &al->al_ri_gh);
> + /* We need to hold the rindex unless the inode we're using is
> + the rindex itself, in which case it's already held. */
> + if (ip != GFS2_I(sdp->sd_rindex))
> + error = gfs2_rindex_hold(sdp, &al->al_ri_gh);
> + else if (!sdp->sd_rgrps) /* We may not have the rindex read in, so: */
> + error = gfs2_check_rindex_version(sdp);
> +
I don't see why we need this change, the original looks correct.
So there are the two distinct parts to the fs-grow procedure. The first
is writing to the rindex and statfs files -- this is what was missing in
gfs2, and I'm ignoring that part for now.
The second part is gfs detecting that a grow took place and updating its
list of rg's. I don't think this part needs any changing at all, it
should work the same way it always has -- this is what I'm focussing on.
Dave
next prev parent reply other threads:[~2007-05-04 20:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 1:57 [Cluster-devel] [PATCH] GFS2: kernel changes to support new gfs2_grow command (Try 3) Robert Peterson
2007-05-04 16:47 ` David Teigland
2007-05-04 21:35 ` Robert Peterson
2007-05-04 22:16 ` David Teigland
2007-05-04 19:37 ` David Teigland
2007-05-04 21:37 ` Robert Peterson
2007-05-08 14:56 ` Robert Peterson
2007-05-04 20:23 ` David Teigland [this message]
2007-05-04 21:48 ` Robert Peterson
2007-05-04 22:04 ` David Teigland
2007-05-08 14:17 ` Robert Peterson
2007-05-08 14:24 ` Steven Whitehouse
-- strict thread matches above, loose matches on Subject: below --
2007-05-08 20:42 David Teigland
2007-05-08 20:43 David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070504202317.GA16877@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).