* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2007-05-08 18:11 wcheng
0 siblings, 0 replies; 9+ messages in thread
From: wcheng @ 2007-05-08 18:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: wcheng at sourceware.org 2007-05-08 18:11:07
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
GFS(s) expects NFS fh_type and fh_len would have the same value.
This is not correct. One obvious symptom is that it will fail NFS
V2 (that uses fixed fh_len for all requests) mount command.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&r1=1.9&r2=1.10
--- cluster/gfs-kernel/src/gfs/ops_export.c 2007/01/24 14:44:19 1.9
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2007/05/08 18:11:06 1.10
@@ -62,9 +62,6 @@
atomic_inc(&get_v2sdp(sb)->sd_ops_export);
- if (fh_type != fh_len)
- return NULL;
-
memset(&parent, 0, sizeof(struct inode_cookie));
switch (fh_type) {
^ permalink raw reply [flat|nested] 9+ messages in thread* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2008-02-20 21:50 fabbione
0 siblings, 0 replies; 9+ messages in thread
From: fabbione @ 2008-02-20 21:50 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: fabbione at sourceware.org 2008-02-20 21:50:00
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Sync missing commit from RHEL5 branch:
Dmitry Monakhov from OpenVZ linux kernel team reports about wrong locking
order in gfs_get_parent(). Patch submitted by Vasily Averin (vvs at sw.ru)
under Red Hat bugzilla 400651
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&r1=1.13&r2=1.14
--- cluster/gfs-kernel/src/gfs/ops_export.c 2008/01/28 06:29:25 1.13
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2008/02/20 21:50:00 1.14
@@ -212,12 +212,12 @@
ip = get_gl2ip(i_gh.gh_gl);
- gfs_glock_dq_uninit(&d_gh);
- gfs_glock_dq_uninit(&i_gh);
-
inode = gfs_iget(ip, CREATE);
gfs_inode_put(ip);
+ gfs_glock_dq_uninit(&d_gh);
+ gfs_glock_dq_uninit(&i_gh);
+
if (!inode)
return ERR_PTR(-ENOMEM);
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2008-01-02 15:07 wcheng
0 siblings, 0 replies; 9+ messages in thread
From: wcheng @ 2008-01-02 15:07 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: wcheng at sourceware.org 2008-01-02 15:07:07
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Dmitry Monakhov from OpenVZ linux kernel team reports about wrong locking
order in gfs_get_parent(). Patch submitted by Vasily Averin (vvs at sw.ru)
under Red Hat bugzilla 400651
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.8.2.3&r2=1.8.2.4
--- cluster/gfs-kernel/src/gfs/ops_export.c 2007/06/05 05:43:14 1.8.2.3
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2008/01/02 15:07:06 1.8.2.4
@@ -254,12 +254,12 @@
ip = get_gl2ip(i_gh.gh_gl);
- gfs_glock_dq_uninit(&d_gh);
- gfs_glock_dq_uninit(&i_gh);
-
inode = gfs_iget(ip, CREATE);
gfs_inode_put(ip);
+ gfs_glock_dq_uninit(&d_gh);
+ gfs_glock_dq_uninit(&i_gh);
+
if (!inode)
return ERR_PTR(-ENOMEM);
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2007-05-08 18:07 wcheng
0 siblings, 0 replies; 9+ messages in thread
From: wcheng @ 2007-05-08 18:07 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: wcheng at sourceware.org 2007-05-08 18:07:17
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Bugzilla 229346:
Remove incorrect checking - fh_type does not necessarily equal to fh_len.
This checking breaks NFS V2 mount.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.8.2.1&r2=1.8.2.2
--- cluster/gfs-kernel/src/gfs/ops_export.c 2007/01/24 14:46:42 1.8.2.1
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2007/05/08 18:07:17 1.8.2.2
@@ -62,9 +62,6 @@
atomic_inc(&get_v2sdp(sb)->sd_ops_export);
- if (fh_type != fh_len)
- return NULL;
-
memset(&parent, 0, sizeof(struct inode_cookie));
switch (fh_type) {
^ permalink raw reply [flat|nested] 9+ messages in thread* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2007-02-13 5:41 wcheng
0 siblings, 0 replies; 9+ messages in thread
From: wcheng @ 2007-02-13 5:41 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: wcheng at sourceware.org 2007-02-13 05:40:59
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Bugzilla 190475: accidentally passed address of a pointer, instead of pointer,
into gfs_inode_get() in previous checked in. This will make
gfs_inode_get() oops.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.3.2.3&r2=1.3.2.4
--- cluster/gfs-kernel/src/gfs/ops_export.c 2007/01/16 20:39:03 1.3.2.3
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2007/02/13 05:40:59 1.3.2.4
@@ -359,7 +359,7 @@
gfs_glock_dq_uninit(&rgd_gh);
gfs_glock_dq_uninit(&ri_gh);
- error = gfs_inode_get(i_gh.gh_gl, &inum, CREATE, &ip);
+ error = gfs_inode_get(i_gh.gh_gl, inum, CREATE, &ip);
if (error)
goto fail;
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2007-01-24 16:26 rpeterso
0 siblings, 0 replies; 9+ messages in thread
From: rpeterso @ 2007-01-24 16:26 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: STABLE
Changes by: rpeterso at sourceware.org 2007-01-24 16:26:10
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Resolves: bz190756: gfs knows of directories which it chooses
not to display.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=STABLE&r1=1.3.6.1.2.1&r2=1.3.6.1.2.2
--- cluster/gfs-kernel/src/gfs/ops_export.c 2006/02/09 19:01:49 1.3.6.1.2.1
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2007/01/24 16:26:10 1.3.6.1.2.2
@@ -25,6 +25,7 @@
#include "glock.h"
#include "glops.h"
#include "inode.h"
+#include "ops_dentry.h"
#include "ops_export.h"
#include "rgrp.h"
@@ -270,7 +271,7 @@
iput(inode);
return ERR_PTR(-ENOMEM);
}
-
+ dentry->d_op = &gfs_dops;
return dentry;
fail:
@@ -390,6 +391,7 @@
return ERR_PTR(-ENOMEM);
}
+ dentry->d_op = &gfs_dops;
return dentry;
fail_relse:
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2007-01-24 14:46 rpeterso
0 siblings, 0 replies; 9+ messages in thread
From: rpeterso @ 2007-01-24 14:46 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: rpeterso at sourceware.org 2007-01-24 14:46:42
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Resolves: bz 222299: gfs knows of directories which it chooses not
to display
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.8&r2=1.8.2.1
--- cluster/gfs-kernel/src/gfs/ops_export.c 2006/10/13 19:57:07 1.8
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2007/01/24 14:46:42 1.8.2.1
@@ -25,6 +25,7 @@
#include "glock.h"
#include "glops.h"
#include "inode.h"
+#include "ops_dentry.h"
#include "ops_export.h"
#include "rgrp.h"
@@ -271,6 +272,7 @@
return ERR_PTR(-ENOMEM);
}
+ dentry->d_op = &gfs_dops;
return dentry;
fail:
@@ -389,6 +391,7 @@
return ERR_PTR(-ENOMEM);
}
+ dentry->d_op = &gfs_dops;
return dentry;
fail_relse:
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2007-01-24 14:44 rpeterso
0 siblings, 0 replies; 9+ messages in thread
From: rpeterso @ 2007-01-24 14:44 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: rpeterso at sourceware.org 2007-01-24 14:44:20
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Resolves: bz 222299: gfs knows of directories which it chooses not
to display
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&r1=1.8&r2=1.9
--- cluster/gfs-kernel/src/gfs/ops_export.c 2006/10/13 19:57:07 1.8
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2007/01/24 14:44:19 1.9
@@ -25,6 +25,7 @@
#include "glock.h"
#include "glops.h"
#include "inode.h"
+#include "ops_dentry.h"
#include "ops_export.h"
#include "rgrp.h"
@@ -271,6 +272,7 @@
return ERR_PTR(-ENOMEM);
}
+ dentry->d_op = &gfs_dops;
return dentry;
fail:
@@ -389,6 +391,7 @@
return ERR_PTR(-ENOMEM);
}
+ dentry->d_op = &gfs_dops;
return dentry;
fail_relse:
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c
@ 2007-01-11 18:52 rpeterso
0 siblings, 0 replies; 9+ messages in thread
From: rpeterso @ 2007-01-11 18:52 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: rpeterso at sourceware.org 2007-01-11 18:52:19
Modified files:
gfs-kernel/src/gfs: ops_export.c
Log message:
Resolves: bz190756: gfs knows of directories which it chooses
not to display.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.3.2.1&r2=1.3.2.2
--- cluster/gfs-kernel/src/gfs/ops_export.c 2006/02/09 18:52:20 1.3.2.1
+++ cluster/gfs-kernel/src/gfs/ops_export.c 2007/01/11 18:52:18 1.3.2.2
@@ -25,6 +25,7 @@
#include "glock.h"
#include "glops.h"
#include "inode.h"
+#include "ops_dentry.h"
#include "ops_export.h"
#include "rgrp.h"
@@ -270,7 +271,7 @@
iput(inode);
return ERR_PTR(-ENOMEM);
}
-
+ dentry->d_op = &gfs_dops;
return dentry;
fail:
@@ -390,6 +391,7 @@
return ERR_PTR(-ENOMEM);
}
+ dentry->d_op = &gfs_dops;
return dentry;
fail_relse:
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-02-20 21:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-08 18:11 [Cluster-devel] cluster/gfs-kernel/src/gfs ops_export.c wcheng
-- strict thread matches above, loose matches on Subject: below --
2008-02-20 21:50 fabbione
2008-01-02 15:07 wcheng
2007-05-08 18:07 wcheng
2007-02-13 5:41 wcheng
2007-01-24 16:26 rpeterso
2007-01-24 14:46 rpeterso
2007-01-24 14:44 rpeterso
2007-01-11 18:52 rpeterso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).