From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/luci/site/luci/Extensions ResourceHandler.py
Date: 22 May 2007 17:12:29 -0000 [thread overview]
Message-ID: <20070522171229.22868.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Branch: EXPERIMENTAL
Changes by: rmccabe at sourceware.org 2007-05-22 17:12:25
Modified files:
luci/site/luci/Extensions: ResourceHandler.py
Log message:
The primary keys for SAPDatabase and SAPInstance are 'SID' and 'SAPInstance', respectively, not 'name'.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/site/luci/Extensions/ResourceHandler.py.diff?cvsroot=cluster&only_with_tag=EXPERIMENTAL&r1=1.1.2.4&r2=1.1.2.5
--- conga/luci/site/luci/Extensions/Attic/ResourceHandler.py 2007/05/22 02:45:54 1.1.2.4
+++ conga/luci/site/luci/Extensions/Attic/ResourceHandler.py 2007/05/22 17:12:25 1.1.2.5
@@ -674,16 +674,8 @@
def addSAPDatabase(res, rname, form, model):
errors = list()
- try:
- sid = form['SID'].strip()
- if not sid:
- raise KeyError, 'No SAP system identifier was given.'
- res.addAttribute('SID', sid)
- except Exception, e:
- err = str(e)
- errors.append(err)
- if LUCI_DEBUG_MODE is True:
- luci_log.debug_verbose('addSAPD0: %s' % err)
+ res.removeAttribute('name')
+ res.addAttribute('SID', rname)
try:
dbtype = form['DBTYPE'].strip()
@@ -720,16 +712,8 @@
def addSAPInstance(res, rname, form, model):
errors = list()
- try:
- iname = form['InstanceName'].strip()
- if not iname:
- raise KeyError, 'No SAP instance name was given.'
- res.addAttribute('InstanceName', iname)
- except Exception, e:
- err = str(e)
- errors.append(err)
- if LUCI_DEBUG_MODE is True:
- luci_log.debug_verbose('addSAPI0: %s' % err)
+ res.removeAttribute('name')
+ res.addAttribute('InstanceName', rname)
# Optional string parameters
for param in [ 'DIR_EXECUTABLE', 'DIR_PROFILE', 'START_PROFILE' ]:
next reply other threads:[~2007-05-22 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 17:12 rmccabe [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-18 21:49 [Cluster-devel] conga/luci/site/luci/Extensions ResourceHandler.py rmccabe
2008-04-28 3:54 rmccabe
2008-04-29 16:09 rmccabe
2008-04-29 16:10 rmccabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070522171229.22868.qmail@sourceware.org \
--to=rmccabe@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).