From: wcheng@sourceware.org <wcheng@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/gfs ops_inode.c
Date: 5 Jun 2007 18:21:23 -0000 [thread overview]
Message-ID: <20070605182123.31664.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: wcheng at sourceware.org 2007-06-05 18:21:23
Modified files:
gfs-kernel/src/gfs: ops_inode.c
Log message:
Bugzilla 242759:
Bump into this problem while debugging bug #236565 (GFS SPECsfs panic).
Apparently a minor oversight while adding new function into GFS for
RHEL5. GFS versions <= RHEL4 is immuned from this issue.
Upon memory pressure, VM starts to release inode cache entries that would
fail gfs iget. GFS1 flags this error as "ENOMEM" but returns from gfs_create
call without releasing the glock.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_inode.c.diff?cvsroot=cluster&r1=1.17&r2=1.18
--- cluster/gfs-kernel/src/gfs/ops_inode.c 2007/06/05 18:15:51 1.17
+++ cluster/gfs-kernel/src/gfs/ops_inode.c 2007/06/05 18:21:22 1.18
@@ -151,9 +151,9 @@
gfs_inode_put(ip);
if (!inode)
- return -ENOMEM;
-
- error = gfs_security_init(dip, ip);
+ error = -ENOMEM;
+ else
+ error = gfs_security_init(dip, ip);
gfs_glock_dq_uninit(&d_gh);
gfs_glock_dq_uninit(&i_gh);
next reply other threads:[~2007-06-05 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 18:21 wcheng [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-11 22:15 [Cluster-devel] cluster/gfs-kernel/src/gfs ops_inode.c rpeterso
2007-07-11 21:58 rpeterso
2007-06-29 21:57 rpeterso
2007-06-05 17:46 wcheng
2007-01-18 20:40 wcheng
2006-10-23 20:47 bmarzins
2006-10-15 7:25 wcheng
2006-10-03 17:27 rohara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605182123.31664.qmail@sourceware.org \
--to=wcheng@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).