From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Date: Tue, 10 Jul 2007 10:06:39 +0100
Subject: [Cluster-devel] Re: [PATCH] [GFS2] Remove i_mode passing from NFS
	File Handle
In-Reply-To: <11839970963525-git-send-email-swhiteho@redhat.com>
References: <11839970793713-git-send-email-swhiteho@redhat.com>
	<11839970813260-git-send-email-swhiteho@redhat.com>
	<11839970832750-git-send-email-swhiteho@redhat.com>
	<11839970852076-git-send-email-swhiteho@redhat.com>
	<11839970871671-git-send-email-swhiteho@redhat.com>
	<1183997089710-git-send-email-swhiteho@redhat.com>
	<11839970914023-git-send-email-swhiteho@redhat.com>
	<11839970921764-git-send-email-swhiteho@redhat.com>
	<11839970941232-git-send-email-swhiteho@redhat.com>
	<11839970963525-git-send-email-swhiteho@redhat.com>
Message-ID: <20070710090639.GA28029@infradead.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

> -#define GFS2_LARGE_FH_SIZE 10
> -
> -struct gfs2_fh_obj {
> -	struct gfs2_inum_host this;
> -	u32 imode;
> -};
> +#define GFS2_LARGE_FH_SIZE 8

Because gfs2_decode_fh only accepts file handles with GFS2_LARGE_FH_SIZE
or GFS2_LARGE_FH_SIZE you don't accept filehandles sent out by and older
gfs version anymore.  Stale filehandles because of a new kernel version
are a big no-no, so please add back code to handle the old filehandles
on the decode side.