From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/luci/cluster validate_fence.js
Date: 23 Jul 2007 15:09:17 -0000 [thread overview]
Message-ID: <20070723150917.28575.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: conga
Branch: RHEL5
Changes by: rmccabe at sourceware.org 2007-07-23 15:09:17
Modified files:
luci/cluster : validate_fence.js
Log message:
Fix code that could cause javascript errors when adding fence devices for the first time with gecko-based browsers (firefox/mozilla/etc).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/cluster/validate_fence.js.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1.2.3&r2=1.1.2.4
--- conga/luci/cluster/validate_fence.js 2007/07/12 04:41:39 1.1.2.3
+++ conga/luci/cluster/validate_fence.js 2007/07/23 15:09:17 1.1.2.4
@@ -258,7 +258,15 @@
for (var j = 0 ; j < select_elem.length ; j++) {
temp += '<input type="text" name="' + escapeXML(select_elem[j].name) + '" value="' + escapeXML(select_elem[j].options[select_elem[j].options.selectedIndex].value) + '" />';
}
- form_xml += '<form id="' + escapeXML(form[i].attributes['name'].value) + '">' + temp + '</form>';
+ var form_name = '';
+
+ try {
+ form_name = form[i].attributes['name'].value;
+ } catch (e) {
+ form_name = form[i].getAttribute('name');
+ }
+
+ form_xml += '<form id="' + escapeXML(form_name) + '">' + temp + '</form>';
}
master_form.fence_xml.value = '<formlist>' + form_xml + '</formlist>';
next reply other threads:[~2007-07-23 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 15:09 rmccabe [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-23 17:23 [Cluster-devel] conga/luci/cluster validate_fence.js rmccabe
2007-07-26 4:14 rmccabe
2007-02-16 23:26 rmccabe
2007-02-16 23:25 rmccabe
2006-10-04 17:25 kupcevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723150917.28575.qmail@sourceware.org \
--to=rmccabe@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).