From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] [GFS2] Clean up run_queue()
Date: Thu, 2 Aug 2007 08:39:07 -0500 [thread overview]
Message-ID: <20070802133907.GA32611@redhat.com> (raw)
In-Reply-To: <11857879472203-git-send-email-swhiteho@redhat.com>
On Mon, Jul 30, 2007 at 10:32:15AM +0100, Steven Whitehouse wrote:
> A further clean up to make the logic a bit more obvious and
> remove a local variable which is no longer required.
>
> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 65d6eba..79d61ff 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -564,24 +564,19 @@ static int rq_demote(struct gfs2_glock *gl)
> */
> static void run_queue(struct gfs2_glock *gl)
> {
> - int blocked;
> -
> - for (;;) {
> - blocked = 1;
> - if (test_bit(GLF_LOCK, &gl->gl_flags))
> - break;
> -
> + while(test_bit(GLF_LOCK, &gl->gl_flags) == 0) {
CodingStyle requires a space after while
prev parent reply other threads:[~2007-08-02 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 9:32 [Cluster-devel] [GFS2] Clean up glock layer Steven Whitehouse
2007-07-30 9:32 ` [Cluster-devel] [PATCH] [GFS2] Clean up arguments to rq_mutex/rq_promote Steven Whitehouse
2007-07-30 9:32 ` [Cluster-devel] [PATCH] [GFS2] Clean up run_queue() Steven Whitehouse
2007-07-30 9:32 ` [Cluster-devel] [PATCH] [GFS2] Merge ->go_drop_th() with ->go_xmote_th() Steven Whitehouse
2007-07-30 9:32 ` [Cluster-devel] [PATCH] [GFS2] Merge gfs2_glock_drop_th() into gfs2_glock_xmote_th() Steven Whitehouse
2007-07-30 9:32 ` [Cluster-devel] [PATCH] [GFs2] Remove reclaim logic from rq_promote() Steven Whitehouse
2007-08-02 13:39 ` David Teigland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070802133907.GA32611@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).