From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
Date: Tue, 7 Aug 2007 21:51:49 +0100 [thread overview]
Message-ID: <20070807205145.GB30159@infradead.org> (raw)
In-Reply-To: <200708061354.l76Ds6sq002260@dantu.rdu.redhat.com>
> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr)
This function badly needs a kerneldoc description. Also I can't say
I like the name a lot, but without a clearly better idea I should
probably not complain :)
We should at least add a generic_ prefix to indicate it's a generic
helper valid for most filesystem (and the kerneldoc comment can explain
the details)
next prev parent reply other threads:[~2007-08-07 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 13:54 [Cluster-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function Jeff Layton
[not found] ` <E1II6cM-0004yj-00@dorka.pomaz.szeredi.hu>
2007-08-06 18:13 ` [Cluster-devel] Re: [fuse-devel] " Jeff Layton
[not found] ` <E1II7JR-0005BN-00@dorka.pomaz.szeredi.hu>
2007-08-06 19:04 ` Trond Myklebust
[not found] ` <E1II8Nw-0005XH-00@dorka.pomaz.szeredi.hu>
2007-08-06 21:23 ` Trond Myklebust
2007-08-07 20:51 ` Christoph Hellwig [this message]
2007-08-07 22:20 ` [Cluster-devel] " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807205145.GB30159@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).