From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 7 Aug 2007 21:51:49 +0100 Subject: [Cluster-devel] Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function In-Reply-To: <200708061354.l76Ds6sq002260@dantu.rdu.redhat.com> References: <200708061354.l76Ds6sq002260@dantu.rdu.redhat.com> Message-ID: <20070807205145.GB30159@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > +void attr_kill_to_mode(struct inode *inode, struct iattr *attr) This function badly needs a kerneldoc description. Also I can't say I like the name a lot, but without a clearly better idea I should probably not complain :) We should at least add a generic_ prefix to indicate it's a generic helper valid for most filesystem (and the kerneldoc comment can explain the details)