From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan McCabe Date: Thu, 30 Aug 2007 13:53:29 -0400 Subject: [Cluster-devel] [RFC] Switch the entire project to use -Werror In-Reply-To: <20070830173846.GW17551@redhat.com> References: <46D11608.5060501@ubuntu.com> <20070830173846.GW17551@redhat.com> Message-ID: <20070830175329.GA156481@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Aug 30, 2007 at 01:38:46PM -0400, Lon Hohberger wrote: > I agree. Clean code is a good thing. > > However, others may / may not want to comment. GCC can still be really stupid and issue warnings about code that's perfectly fine, for example: [rmccabe at sublimit ~]$ cat test.c int main(void) { int x, y = 1; if (y || x) x = 1; return 0; } [rmccabe at sublimit ~]$ gcc -O2 -Wall -Werror test.c -o test cc1: warnings being treated as errors test.c: In function ?main?: test.c:3: warning: ?x? is used uninitialized in this function Ryan