From: teigland@sourceware.org <teigland@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/dlm thread.c
Date: 31 Aug 2007 15:23:33 -0000 [thread overview]
Message-ID: <20070831152333.12394.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL4
Changes by: teigland at sourceware.org 2007-08-31 15:23:33
Modified files:
gfs-kernel/src/dlm: thread.c
Log message:
Check for a null lvb pointer before trying to memset the lvb to zero.
I think there's a good chance this will fix bz 176838.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/dlm/thread.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.16.2.5&r2=1.16.2.6
--- cluster/gfs-kernel/src/dlm/Attic/thread.c 2006/12/08 17:31:31 1.16.2.5
+++ cluster/gfs-kernel/src/dlm/Attic/thread.c 2007/08/31 15:23:32 1.16.2.6
@@ -116,8 +116,13 @@
goto out;
}
- if (lp->lksb.sb_flags & DLM_SBF_VALNOTVALID)
- memset(lp->lksb.sb_lvbptr, 0, DLM_LVB_LEN);
+ if (lp->lksb.sb_flags & DLM_SBF_VALNOTVALID) {
+ if (lp->lksb.sb_lvbptr)
+ memset(lp->lksb.sb_lvbptr, 0, DLM_LVB_LEN);
+ else
+ log_all("no lvb for VALNOTVALID lkid %x",
+ lp->lksb.sb_lkid);
+ }
if (lp->lksb.sb_flags & DLM_SBF_ALTMODE) {
if (lp->req == DLM_LOCK_PR)
next reply other threads:[~2007-08-31 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 15:23 teigland [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-14 16:00 [Cluster-devel] cluster/gfs-kernel/src/dlm thread.c teigland
2006-12-08 17:31 teigland
2006-12-08 17:31 teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070831152333.12394.qmail@sourceware.org \
--to=teigland@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).